Merged
Conversation
48f8b59 to
e7ba310
Compare
e7ba310 to
4de47b5
Compare
|
julianoes
commented
Aug 11, 2025
Collaborator
Author
julianoes
left a comment
There was a problem hiding this comment.
Self reviewed again, I think it's ok.
| #if defined(LINUX) || defined(APPLE) | ||
| send_len = static_cast<int>(write(_fd, bytes, length)); | ||
| #else | ||
| if (!WriteFile(_handle, bytes, static_cast<DWORD>(length), LPDWORD(&send_len), NULL)) { |
Collaborator
There was a problem hiding this comment.
Isn't this a Windows function? 🤔
Collaborator
Author
There was a problem hiding this comment.
I believe so. It was there before, it just moved.
Collaborator
There was a problem hiding this comment.
Oh you're right. So I guess we don't use this function on iOS or Android 🤷
Collaborator
|
This is cool! |
julianoes
added a commit
that referenced
this pull request
Dec 10, 2025
This fixes a major flaw that was introduced with #2637 leading to invalid messages being parsed, instead of only forwarded, as was the intention. The fix is to: - Process and forward if CRC is valid - forward only if CRC is invalid (for unknown or invalid message)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem that MAVSDK did not forward messages which it had not seen before. This could happen when: