Skip to content

Tests for /rooms/:room_id/aliases#809

Merged
richvdh merged 2 commits intodevelopfrom
rav/list_room_aliases
Feb 18, 2020
Merged

Tests for /rooms/:room_id/aliases#809
richvdh merged 2 commits intodevelopfrom
rav/list_room_aliases

Conversation

@richvdh
Copy link
Member

@richvdh richvdh commented Feb 18, 2020

@richvdh richvdh requested a review from a team February 18, 2020 15:01
anoadragon453
anoadragon453 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though may be worth adding a test for server admins being able to query the aliases of a room for which they're not in?

@babolivier
Copy link
Contributor

babolivier commented Feb 18, 2020

lgtm, though may be worth adding a test for server admins being able to query the aliases of a room for which they're not in?

IMHO that should happen in the unit tests of the Synapse PR since server admins aren't a Matrix spec thing.

@anoadragon453
Copy link
Member

anoadragon453 commented Feb 18, 2020

server admins aren't a Matrix spec thing

Very good point. We should probably convert https://github.com/matrix-org/sytest/blob/d0c105b30f0db89ab118f39052e1e3885946d973/tests/48admin.pl to unit tests at some point as well.

@richvdh
Copy link
Member Author

richvdh commented Feb 18, 2020

IMHO that should happen in the unit tests of the Synapse PR since server admins aren't a Matrix spec thing.

+1

We should probably convert https://github.com/matrix-org/sytest/blob/d0c105b30f0db89ab118f39052e1e3885946d973/tests/48admin.pl to unit tests at some point as well.

+1

@richvdh richvdh merged commit 37cbb36 into develop Feb 18, 2020
@richvdh richvdh deleted the rav/list_room_aliases branch February 18, 2020 16:23
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
@anoadragon453
Merge remote-tracking branch 'origin/release-v1.11.0' into dinsic-rel…
5747b0b 
…ease-v1.11.x

* origin/release-v1.11.0:
  Port changes from 30rooms/70publicroomslist.pl to 50federation/40publicroomlist.pl to fix flaky test.
  Move /rooms/:room_id/aliases onto an unstable prefix (#810)
  Tests for /rooms/:room_id/aliases (#809)
  Route /publicised_groups/ to client reader (#807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@richvdh @babolivier @anoadragon453