Skip to content

Route /publicised_groups/ to client reader#807

Merged
erikjohnston merged 3 commits intodevelopfrom
erikj/test_publicised_groups
Feb 18, 2020
Merged

Route /publicised_groups/ to client reader#807
erikjohnston merged 3 commits intodevelopfrom
erikj/test_publicised_groups

Conversation

@erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Feb 18, 2020 •
edited
Loading

This is to test that we can point publicised groups API to client reader.

@erikjohnston erikjohnston force-pushed the erikj/test_publicised_groups branch from d38d0bb to 65d15a9 Compare February 18, 2020 11:46
@erikjohnston erikjohnston requested a review from a team February 18, 2020 12:05
@erikjohnston erikjohnston mentioned this pull request Feb 18, 2020
Merged
richvdh
richvdh approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combine the two?

^/_matrix/client/(api/v1|r0|unstable)/publicised_groups           client_reader

lgtm either way

@erikjohnston
Copy link
Member Author

erikjohnston commented Feb 18, 2020

I'm not a huge fan of that given people might add a different API like /publicised_groups_to_delete or something

@erikjohnston erikjohnston merged commit 97fbd25 into develop Feb 18, 2020
@erikjohnston erikjohnston deleted the erikj/test_publicised_groups branch February 18, 2020 16:16
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
@anoadragon453
Merge remote-tracking branch 'origin/release-v1.11.0' into dinsic-rel…
5747b0b 
…ease-v1.11.x

* origin/release-v1.11.0:
  Port changes from 30rooms/70publicroomslist.pl to 50federation/40publicroomlist.pl to fix flaky test.
  Move /rooms/:room_id/aliases onto an unstable prefix (#810)
  Tests for /rooms/:room_id/aliases (#809)
  Route /publicised_groups/ to client reader (#807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richvdh richvdh richvdh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erikjohnston @richvdh