workaround for https://github.com/matrix-org/synapse/issues/6536#772
workaround for https://github.com/matrix-org/synapse/issues/6536#772
Conversation
I feel like there are going to be a lot of these
2d965b1 to
b7f1479
Compare
| log_if_fail "Joined room $room_id"; | ||
|
|
||
| # workaround for https://github.com/matrix-org/synapse/issues/6536 | ||
| delay( 0.5 ); |
There was a problem hiding this comment.
I'd really rather avoid adding delays if possible given how long it takes to run sytest anyway. Can we not wait for the join to come down a sync? I know that's not quite the same, but its a heuristic we use elsewhere for similar things
There was a problem hiding this comment.
well... we're waiting for latest_events_in_room to get flushed, not the events stream: and part of the problem is that latest_events_in_room is flushed after the events stream.
so yeah we could wait for a sync and it would probably work, but really we'd just be using it as a proxy for "wait a bit", which we may as well do with a delay.
Compromise: we could make it only delay in worker mode?
There was a problem hiding this comment.
Yeah, doing that would help. It's fine for now I guess, I just don't want to end up in a situation where we delay in loads of tests, which I could see happening more and more as we continue to split things apart
There was a problem hiding this comment.
... the right solution might be to fix the bug?
…ase-v1.8.x * origin/release-v1.8.0: (27 commits) Test for outliers whose auth events are in a different room Test for receiving events with auth events in the wrong room enable frozen dicts in synapse (#778) Fix c&p error in #779 Add support for synapse multi DB setups. (#775) Add console feedbak for the TAP output mode (#779) workaround for matrix-org/synapse#6536 (#772) Test for backfilled events whose prev_events cross room boundaries (#769) Add dendrite's logs to buildkite's artifacts (#773) Make the replication torture level adjustable (#771) Add test for removing redactions from search results (#747) Sanity-checking of some params (#765) Fix some 'undefined value' warnings (#768) Remove redundant fallback in on_request_federation_v1_event (#766) Deflake an AS test (#764) Add tests for outbound v2 invite API Fix diagnostics from logout test (#763) Add comment to explain what the v1 outbound test relies on Re-fix test names Fix test names ...
(matrix-org/synapse#6536)
I feel like there are going to be a lot of these