Deflake "Inviting an AS-hosted user asks the AS server"#764
Merged
Conversation
We need to make sure the AS is ready for the event before synapse sends it, otherwise we might miss it.
richvdh
commented
Dec 11, 2019
| }); | ||
|
|
||
| matrix_invite_user_to_room( $creator, $user_id, $room_id ) | ||
| ->SyTest::pass_on_done( "Sent invite" ) |
Member
Author
There was a problem hiding this comment.
this is pretty redundant, since matrix_invite_user_to_room does a log_on_fail when the invite is sent. And since this is the only pass_on_done, we may as well convert from a multi_test to a regular test.
erikjohnston
approved these changes
Dec 12, 2019
anoadragon453
added a commit
that referenced
this pull request
Mar 20, 2020
…ase-v1.8.x * origin/release-v1.8.0: (27 commits) Test for outliers whose auth events are in a different room Test for receiving events with auth events in the wrong room enable frozen dicts in synapse (#778) Fix c&p error in #779 Add support for synapse multi DB setups. (#775) Add console feedbak for the TAP output mode (#779) workaround for matrix-org/synapse#6536 (#772) Test for backfilled events whose prev_events cross room boundaries (#769) Add dendrite's logs to buildkite's artifacts (#773) Make the replication torture level adjustable (#771) Add test for removing redactions from search results (#747) Sanity-checking of some params (#765) Fix some 'undefined value' warnings (#768) Remove redundant fallback in on_request_federation_v1_event (#766) Deflake an AS test (#764) Add tests for outbound v2 invite API Fix diagnostics from logout test (#763) Add comment to explain what the v1 outbound test relies on Re-fix test names Fix test names ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to make sure the AS is ready for the event before synapse sends it,
otherwise we might miss it.