This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Don't include appservice users when calculating push rules#13332
Merged
erikjohnston merged 4 commits intorelease-v1.63from Jul 20, 2022
Merged
Don't include appservice users when calculating push rules#13332erikjohnston merged 4 commits intorelease-v1.63from
erikjohnston merged 4 commits intorelease-v1.63from
Conversation
Member
|
Is this something we should have a unit test for? |
Member
Author
|
Testing is cheating! (yes we should) |
Member
Author
|
I've added a dodgy test, and confirmed it breaks on v1.63.0 |
DMRobertson
approved these changes
Jul 20, 2022
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
SGTM otherwise. Shame we (I?) missed this in review.
Do we want to do a 1.63.1 release with this fix?
Co-authored-by: David Robertson <davidr@element.io>
Member
Author
I think so, yes |
Member
Thank you! |
Fizzadar
pushed a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Aug 23, 2022
Synapse 1.63.1 (2022-07-20) =========================== Bugfixes -------- - Fix a bug introduced in Synapse 1.63.0 where push actions were incorrectly calculated for appservice users. This caused performance issues on servers with large numbers of appservices. ([\matrix-org#13332](matrix-org#13332))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078