This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Don't pull out the full state when calculating push actions#13078
Merged
erikjohnston merged 56 commits intodevelopfrom Jul 11, 2022
Merged
Don't pull out the full state when calculating push actions#13078erikjohnston merged 56 commits intodevelopfrom
erikjohnston merged 56 commits intodevelopfrom
Conversation
3ce63fd to
2e4be71
Compare
2e4be71 to
f7ace02
Compare
erikjohnston
commented
Jun 29, 2022
erikjohnston
commented
Jul 5, 2022
erikjohnston
commented
Jul 5, 2022
erikjohnston
commented
Jul 5, 2022
erikjohnston
commented
Jul 5, 2022
erikjohnston
commented
Jul 5, 2022
erikjohnston
commented
Jul 5, 2022
Member
Author
|
Thanks Shay, this is really starting to look good! Had a quick look through what is currently there (not sure if it was ready for my review or not!), and it's mostly comments around getting the caching correct (which is always the really fiddly and brittle part). LMK if you want to jump on a call to discuss, exactly how to do caching isn't exactly obvious. |
erikjohnston
commented
Jul 5, 2022
DMRobertson
reviewed
Jul 11, 2022
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
TL;DR: nothing looks wrong; it looks simpler; it seems sane. Nitpicks and general reviewer arsey remains.
DMRobertson
approved these changes
Jul 11, 2022
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Sytest failure looks to be matrix-org/sytest#1125.
LGTM otherwise; I'm happy if CI is happy.
erikjohnston
added a commit
that referenced
this pull request
Jul 20, 2022
This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12653