Consider url scheme to detect and handle external URLs#57
Merged
manuzhang merged 15 commits intomanuzhang:mainfrom Apr 11, 2023
kolibri91:feature/consider-url-scheme
Merged
Consider url scheme to detect and handle external URLs#57manuzhang merged 15 commits intomanuzhang:mainfrom kolibri91:feature/consider-url-scheme
manuzhang merged 15 commits intomanuzhang:mainfrom
kolibri91:feature/consider-url-scheme
Conversation
Owner
|
LGTM. Please fix styles issues in #55 |
Merged
Contributor
Author
|
Contributor
Author
|
@manuzhang Did you consider to activate branch protection rule "up to date". This would ensure that the PRs contains latest changes. |
Owner
|
It doesn't have to as long as there's no conflict. |
Contributor
Author
|
I noticed in my daily work two common issues with branches which are not up to date before you merge. It can happen that the ci does not work correctly if main branch contains CI configuration updates. Secondly, auto-merge can break styling. In both cases, it would end in a broken main branch and that's always a bad sign. |
manuzhang
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the plugin by doing two things:
Further, I improved the logging by using the provided functionality of
mkdocs.utils.log.Unfortunately, I noticed there are several
flake8issues in the existing code after my changes.They are not correctly recognized like I showed in #55.
I fixed them all in this branch, I would prefer if we could merge those changes pragmatic in that PR and avoid a extract and conflict resolution.
Closes #54
Closes #55