Show bad configured CI#55
Merged
manuzhang merged 4 commits intomanuzhang:mainfrom Apr 10, 2023
kolibri91:fix/ci
Merged
Conversation
This was referenced Apr 7, 2023
manuzhang
reviewed
Apr 8, 2023
| flake8 htmlproofer/ tests/ setup.py --count --select=E9,F63,F7,F82 --show-source --statistics | ||
| # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide | ||
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics | ||
| flake8 htmlproofer/ tests/ setup.py --count --max-complexity=10 --max-line-length=127 --statistics |
Owner
There was a problem hiding this comment.
the comment above needs update as well
Owner
|
Please help fix style issues after removing |
Contributor
Author
Really? It's done in #57. So, why to double the work? |
Owner
|
I prefer one PR/commit handling one issue. Combing multiple things in one commit make it hard to check history, revert, etc. You may have two commits in #57 with one handling style, the other external URL. |
Contributor
Author
|
Fair point, I would do it in the same way if it's really matters. But the project is rather small and the history is easy to overview. Nevertheless, I will rework the commits |
Contributor
Author
manuzhang
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@manuzhang
Your CI is green even if it contains styling-issues:
e.g. https://github.com/manuzhang/mkdocs-htmlproofer-plugin/actions/runs/4637384298/jobs/8206224207?pr=55
There are two issues:
.--exit-zerois most likely not want you wantI'm going to solve all issues with my next PR. I noticed it after my implementation, so it would be easier to adress it there.