Merged
Conversation
This uses the variable MAINT_CFLAGS to set the project's flags so that the user can set CFLAGS as an environment variable or as an make argument without any conflicts. This can be problemtic with the build environment in some distros.
This can be useful for distro integration.
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 14, 2022
Bug: https://bugs.gentoo.org/793425 Upstream-PR: manugarg/pacparser#136 Upstream-PR: manugarg/pacparser#137 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 14, 2022
Bug: https://bugs.gentoo.org/793425 Upstream-PR: manugarg/pacparser#136 Upstream-PR: manugarg/pacparser#137 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 14, 2022
Bug: https://bugs.gentoo.org/793425 Upstream-PR: manugarg/pacparser#106 Upstream-PR: manugarg/pacparser#136 Upstream-PR: manugarg/pacparser#137 Upstream-Commit: manugarg/pacparser@c6258eb Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 14, 2022
Bug: https://bugs.gentoo.org/793425 Upstream-PR: manugarg/pacparser#106 Upstream-PR: manugarg/pacparser#136 Upstream-PR: manugarg/pacparser#137 Upstream-Commit: manugarg/pacparser@c6258eb Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 14, 2022
Bug: https://bugs.gentoo.org/793425 Upstream-PR: manugarg/pacparser#106 Upstream-PR: manugarg/pacparser#136 Upstream-PR: manugarg/pacparser#137 Upstream-Commit: manugarg/pacparser@c6258eb Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 15, 2022
Bug: https://bugs.gentoo.org/793425 Upstream-PR: manugarg/pacparser#106 Upstream-PR: manugarg/pacparser#136 Upstream-PR: manugarg/pacparser#137 Upstream-Commit: manugarg/pacparser@c6258eb Signed-off-by: orbea <orbea@riseup.net> Closes: #25487 Signed-off-by: Sam James <sam@gentoo.org>
Contributor
Author
Owner
Contributor
Author
|
Thanks for the merge and fixes! |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Oct 27, 2023
Note: patches dropped since they were merged upstream. See manugarg/pacparser#136. Signed-off-by: Guilherme Amadio <amadio@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are trivial build fixes that makes it easier for distros.
CFLAGStoMAINT_CFLAGS. This leavesCFLAGSas unset by default so that the user can freely set it either in the user's environment or as a make argument. The specific variable nameMAINT_CFLAGSis not important and other suggestions as what to call it are welcome of course.DOC_PREFIXso that the user can specifically set the documentation directory duringmake install. For example distros may wish to override thepacparserdirectory topacparser-1.4.0or in Slackware documentation is installed to/usr/doc/and not/usr/share/doc/as in most other distributions.