Skip to content

build: Don't quote $(MAKE)#106

Merged
manugarg merged 1 commit intomanugarg:masterfrom
orbea:make
Mar 23, 2022
Merged

build: Don't quote $(MAKE)#106
manugarg merged 1 commit intomanugarg:masterfrom
orbea:make

Conversation

@orbea
Copy link
Contributor

@orbea orbea commented Jun 1, 2021

The $(MAKE) variable may contain make(1) arguments in addition to the make(1) command.

Downstream issue: https://bugs.gentoo.org/793425

Example:

$ export MAKE='make LIBTOOL=rdlibtool'

$ make -C src/spidermonkey/
make: Entering directory '/tmp/pacparser/src/spidermonkey'
mkdir -p js/src/Linux_All_DBG.OBJ
CFLAGS="" "make LIBTOOL=rdlibtool" -C js/src -f Makefile.ref libjs.a
/bin/sh: make LIBTOOL=rdlibtool: command not found
make: *** [Makefile:37: js-buildstamp] Error 127
make: Leaving directory '/tmp/pacparser/src/spidermonkey

Note that while pacparser does not use libtool in an environment that uses slibtool (Instead of GNU libtool) this issue is exposed. I am sure there are other cases where this can happen too.

The $(MAKE) variable may contain make(1) arguments in addition to
the make(1) command.

Downstream issue: https://bugs.gentoo.org/793425

Signed-off-by: orbea <orbea@riseup.net>
@orbea
Copy link
Contributor Author

orbea commented Aug 4, 2021

@manugarg Is this project still active?

@manugarg manugarg merged commit c6258eb into manugarg:master Mar 23, 2022
@orbea orbea deleted the make branch March 23, 2022 13:49
orbea added a commit to orbea/gentoo that referenced this pull request May 14, 2022
Bug: https://bugs.gentoo.org/793425
Upstream-PR: manugarg/pacparser#106
Upstream-PR: manugarg/pacparser#136
Upstream-PR: manugarg/pacparser#137
Upstream-Commit: manugarg/pacparser@c6258eb
Signed-off-by: orbea <orbea@riseup.net>
orbea added a commit to orbea/gentoo that referenced this pull request May 14, 2022
Bug: https://bugs.gentoo.org/793425
Upstream-PR: manugarg/pacparser#106
Upstream-PR: manugarg/pacparser#136
Upstream-PR: manugarg/pacparser#137
Upstream-Commit: manugarg/pacparser@c6258eb
Signed-off-by: orbea <orbea@riseup.net>
orbea added a commit to orbea/gentoo that referenced this pull request May 14, 2022
Bug: https://bugs.gentoo.org/793425
Upstream-PR: manugarg/pacparser#106
Upstream-PR: manugarg/pacparser#136
Upstream-PR: manugarg/pacparser#137
Upstream-Commit: manugarg/pacparser@c6258eb
Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request May 15, 2022
Bug: https://bugs.gentoo.org/793425
Upstream-PR: manugarg/pacparser#106
Upstream-PR: manugarg/pacparser#136
Upstream-PR: manugarg/pacparser#137
Upstream-Commit: manugarg/pacparser@c6258eb
Signed-off-by: orbea <orbea@riseup.net>
Closes: #25487
Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants