make use of AnnouncementCell#1
Merged
ahukkanen merged 1 commit intomainio:fix/proposal-answer-callout-stylesfrom Dec 4, 2019
Merged
Conversation
Author
|
😄 thanks @ahukkanen |
ahukkanen
pushed a commit
that referenced
this pull request
Nov 25, 2020
* revert keys type in smtp_settings from symbol to strings * switch smtp_settings keys from symbols to strings * Fix smtp settings specs (#2) * light cleanup application mailer specs * add tests in register organization specs * Revert "Fix smtp settings specs (#2)" (decidim#3) This reverts commit 9838bec. * Update organization seeds (#1) * Update organization seeds * Fix migration * Clean tests * Complete migration by adding down * Fix smtp settings specs (decidim#4) * light cleanup application mailer specs * add tests in register organization specs * Remove migration and update CHANGELOG * Remove CHANGELOG entry Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com> Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This pr is a result of reviewing Standardize proposal answer callout styles by ahukkanen · Pull Request #5530 · decidim/decidim which I find fine, but could make use of
AnnouncementCell, I hope you like it.😄
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)