MSI-969: [Configuration-Catalog-Products-Configurable product] Manage Stock on Configuration page turned off in admin for Configurable Product on Default stock#1030
Merged
maghamed merged 3 commits into2.3-developfrom May 10, 2018
Conversation
… Stock on Configuration page turned off in admin for Configurable Product on Default stock
okolesnyk
suggested changes
May 8, 2018
Member
There was a problem hiding this comment.
Please avoid using numbers as stepKey="loginAsAdmin1" or stepKey="fillNameForNewAttribute2"
Try to make them more descriptive like
stepKey="fillNameForRedColorAttribute"
stepKey="fillNameRedColorAttrForConfigurable"
It will help when some other module will want to extend your test.
The only place I see where numbers can be used is here: https://github.com/magento-engcom/msi/pull/1040/files
… Stock on Configuration page turned off in admin for Configurable Product on Default stock
okolesnyk
approved these changes
May 10, 2018
sidolov
pushed a commit
that referenced
this pull request
Nov 4, 2019
- Merge Pull Request magento/graphql-ce#1030 from TomashKhamlai/graphql-ce:cover-customer-address-customizable-attribute - Merged commits: 1. 56382f1 2. a97ef07 3. 461763e
sidolov
pushed a commit
that referenced
this pull request
Nov 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Functional test, which covers managing configurable product variation stock and how it affects configurable product appearance on storefront.
Fixed Issues (if relevant)
Manual testing scenarios
Currently this test scenario is blocked by #1029
Original HipTest ID: 1695735