Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Extend coverage for CustomerGraphQL#1030

Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
TomashKhamlai:cover-customer-address-customizable-attribute
Oct 31, 2019
Merged

Extend coverage for CustomerGraphQL#1030
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
TomashKhamlai:cover-customer-address-customizable-attribute

Conversation

@TomashKhamlai
Copy link
Copy Markdown
Contributor

@TomashKhamlai TomashKhamlai commented Oct 24, 2019

Description (*)

Extend coverage for CustomerGraphQL

  • cover \Magento\CustomerGraphQl\Model\Customer\Address\ExtractCustomerAddressData

Fixed Issues (if relevant)

  1. [Test Coverage] Extend coverage for CustomerGraphQL #1011: [Test Coverage] Extend coverage for CustomerGraphQL

Manual testing scenarios (*)

  1. n/a

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@TomashKhamlai
Extend coverage for CustomerGraphQL
56382f1 
 - cover \Magento\CustomerGraphQl\Model\Customer\Address\ExtractCustomerAddressData

Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
@lenaorobei
Copy link
Copy Markdown
Contributor

lenaorobei commented Oct 25, 2019

@magento run all tests

@lenaorobei
Copy link
Copy Markdown
Contributor

lenaorobei commented Oct 25, 2019

@magento run Integration Tests

@TomashKhamlai TomashKhamlai marked this pull request as ready for review October 25, 2019 16:23
TomashKhamlai and others added 2 commits October 25, 2019 19:29
@TomashKhamlai
Change function name
a97ef07 
The test covers custom attributes. No extension attributes coverage in this function
@lenaorobei
#1011: [Test Coverage] Extend coverage for CustomerGraphQL
461763e
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 28, 2019

Hi @lenaorobei, thank you for the review.
ENGCOM-6192 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team magento-engcom-team mentioned this pull request Oct 31, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Oct 31, 2019
@lenaorobei
ENGCOM-6192: Extend coverage for CustomerGraphQL #1030
efabb8f
@magento-engcom-team magento-engcom-team merged commit 461763e into magento:2.3-develop Oct 31, 2019
@ghost
Copy link
Copy Markdown

ghost commented Oct 31, 2019

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paliarush paliarush Awaiting requested review from paliarush

1 more reviewer

@lenaorobei lenaorobei lenaorobei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lenaorobei lenaorobei

Labels

approved Auto-Tests: Covered Component: CustomerGraphQl Release Line: 2.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomashKhamlai @lenaorobei @magento-engcom-team