Closed
Conversation
Owner
|
Merged, with comment. |
nmoinvaz
pushed a commit
to nmoinvaz/zlib
that referenced
this pull request
May 2, 2020
* PS-237 Don't disable target optimizations when cross-compiling. AFAICT there's no reason to check the host platform here. The test only runs the compiler; it doesn't execute the output. * Add misc intermediate files to .gitignore.
jinfeihan57
pushed a commit
to minchai23/zlib
that referenced
this pull request
Sep 15, 2020
* Internally replace '\' by '/' for entry name. * Add tests
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to add zlib as an external project on linux like so:
I got a couple of errors which I've fixed in this pull request.
wasn't getting parsed correctly with the current regex.
Also,
wasn't finding zlib.map, which may have to do with it being an "external project".