Fix shader cleanup only affecting pipeline#48
Merged
morew4rd merged 1 commit intolyte2d:mainfrom Jan 18, 2024
Zorbn:fix-shader-cleanup
Merged
Fix shader cleanup only affecting pipeline#48morew4rd merged 1 commit intolyte2d:mainfrom Zorbn:fix-shader-cleanup
morew4rd merged 1 commit intolyte2d:mainfrom
Zorbn:fix-shader-cleanup
Conversation
Collaborator
|
🙏 |
morew4rd
added a commit
that referenced
this pull request
Feb 4, 2024
* fix #39 * gitattributes file, to handle crlf better https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings * Normalize all the line endings * fix memory issues - __gc was not correctly set (found and fix provided by Zorbn) - with that fixed, resources in use but not referenced can cause read after free issues. these are: - play_music - set_shader - set_font - set_canvas these now save a reference to the object to prevent premature collection. (previously done in C API) * remove 'lyte/api/defs/output' folder as it gets unnecessarily chatty with the commits * Fix shader cleanup only affecting pipeline (#48) * update sokol_gp to v0.4.1 which fixes the shader leak * image drawing extensions. fixes #45 functions are extended to support angle/scale_x/scale_y etc. * fix manual code: draw_image, repeated angle * lyte.get_textinput() api. progress towards #44 * lyte.get_textinput() api. progress towards #44 (take 2) * utf8.* - full lua 5.3 utf.* functionalilty - some extras used: https://github.com/starwing/luautf8/ * fix build issues * get_pressed_keys() api. fixes #50 * image drawing functions: swap order of origin and scale params --------- Co-authored-by: Zorbn <70043176+Zorbn@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sokol GP creates an internal shader when you call its make pipeline function but doesn't expose it to the user so you can never destroy it. This PR fixes that. The changes to Sokol GP could probably be upstreamed.