Remove duplicate patterns JAVACLASS and JAVAFILE#237
Merged
jsvd merged 1 commit intologstash-plugins:masterfrom Nov 19, 2018
Merged
Remove duplicate patterns JAVACLASS and JAVAFILE#237jsvd merged 1 commit intologstash-plugins:masterfrom
jsvd merged 1 commit intologstash-plugins:masterfrom
Conversation
Member
Author
|
/cc @jakelandis as this duplication also exists in https://github.com/elastic/elasticsearch/blob/6.5/libs/grok/src/main/resources/patterns/java |
robbavey
approved these changes
Nov 19, 2018
Member
Author
@robbavey that was my goal with the tests, both test an example of the pattern that only works for the remaining one. |
Member
|
@jsvd Ah cool, ok LGTM then |
Contributor
|
@jsvd - thanks for the heads up, issue logged for the ingest node: elastic/elasticsearch#35699 |
jakelandis
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Nov 26, 2018
This commit removes the redundant (and incorrect) JAVACLASS and JAVAFILE grok patterns. This helps to keep parity with Logstash's patterns. See also: logstash-plugins/logstash-patterns-core#237 closes #35699
jakelandis
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Nov 26, 2018
This commit removes the redundant (and incorrect) JAVACLASS and JAVAFILE grok patterns. This helps to keep parity with Logstash's patterns. See also: logstash-plugins/logstash-patterns-core#237 closes #35699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.