ingest: grok fix duplicate patterns JAVACLASS and JAVAFILE #35886
Merged
jakelandis merged 1 commit intoelastic:masterfrom Nov 26, 2018
pendext:duplicate_grok_patterns_35699
Merged
ingest: grok fix duplicate patterns JAVACLASS and JAVAFILE #35886jakelandis merged 1 commit intoelastic:masterfrom pendext:duplicate_grok_patterns_35699
jakelandis merged 1 commit intoelastic:masterfrom
pendext:duplicate_grok_patterns_35699
Conversation
Collaborator
|
Pinging @elastic/es-core-features |
Contributor
|
jenkins test this please |
jakelandis
approved these changes
Nov 26, 2018
Contributor
jakelandis
left a comment
There was a problem hiding this comment.
@pendext - thanks for the contribution!
LGTM, will merge and back port to 6.x
jakelandis
pushed a commit
that referenced
this pull request
Nov 26, 2018
This commit removes the redundant (and incorrect) JAVACLASS and JAVAFILE grok patterns. This helps to keep parity with Logstash's patterns. See also: logstash-plugins/logstash-patterns-core#237 closes #35699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logstash commit