Skip to content

tweaks to range comparison fine filtering#168

Merged
rwgdrummer merged 1 commit intomasterfrom
GEOWAVE-167
Jan 7, 2015
Merged

tweaks to range comparison fine filtering#168
rwgdrummer merged 1 commit intomasterfrom
GEOWAVE-167

Conversation

@chrisbennight
Copy link
Copy Markdown
Contributor

Design question/intent before merging

In GeometryWrapper.java, in the case of having only 1 field we have a direct range comparison method. The old version of this did not use a fuzzy compare (i.e. double + epsilon range).

The new version does

  • Is this what we want? I would argue yes - if we use it anywhere, we should use it everywhere (deterministic behaviour). Also, since this is a "rejection" type operation (i.e. we aren't generating a list, rather we are culling an already existing list) we don't have an danger of "wrong" data.
  • This required changing one of the tests to make pass (always a chancy thing) - the value a particular field was incremented by (1E-13) previously caused a failure when the match was exact, but now passed (since the tolerance was 1E-12. The value was reduced to 1E-10 to cause it to fail again. Hopefully I caught the intent of the test.

@chrisbennight
Copy link
Copy Markdown
Contributor Author

#167

rwgdrummer added a commit that referenced this pull request Jan 7, 2015
tweaks to range comparison fine filtering
@rwgdrummer rwgdrummer merged commit e6dda82 into master Jan 7, 2015
@chrisbennight chrisbennight deleted the GEOWAVE-167 branch January 11, 2015 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants