fix APIGW UpdateMethod authorizer validation#7860
Merged
alexrashed merged 2 commits intomasterfrom Mar 14, 2023
Merged
Conversation
calvernaz
approved these changes
Mar 13, 2023
| @@ -492,11 +494,10 @@ def update_method( | |||
| continue | |||
|
|
|||
| if path == "/authorizationType" and value in ("CUSTOM", "COGNITO_USER_POOLS"): | |||
Contributor
There was a problem hiding this comment.
so it either update the type or the id that points to, correct?
Contributor
Author
There was a problem hiding this comment.
Yes, you can:
- Update the type, but if the type is either CUSTOM or COGNITO_USER_POOLS, you also need to provide a valid
AuthorizerIdin the call (so you'd need to provide both). - Update only the ID, it will be taken into account only if the existing authorisation type is CUSTOM or COGNITO_USER_POOLS
I can see there's one scenario missing here, if the type is already CUSTOM and we change it to COGNITO_USER_POOLS, technically I think we'd still need to update the AuthorizerId, but this hasn't been tested against AWS.
The validation logic is these Update* operation is pretty convoluted, and it takes a lot of testing to get all the possible combinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #7749, it seems the validation was lacking and a bit too restrictive while updating Authorizers-related fields. I've added more AWS tests, this should solve our Pro pipeline (tested locally and it works).