Merged
Conversation
47c5f27 to
48f01c1
Compare
a32104e to
0b6bf50
Compare
2c801d5 to
900b216
Compare
0b6bf50 to
a279d83
Compare
80e8476 to
d1da5a4
Compare
f5cb57c to
642d51e
Compare
642d51e to
456136b
Compare
456136b to
d0f78f4
Compare
calvernaz
approved these changes
Mar 11, 2023
| @@ -36,44 +36,6 @@ def apigateway_models_Stage_init( | |||
| apigateway_models_Stage_init_orig = apigateway_models.Stage.__init__ | |||
| apigateway_models.Stage.__init__ = apigateway_models_Stage_init | |||
|
|
|||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements the
Methodresource CRUD API, removing the patches from moto to integrate them in our provider.There was quite some validations on the json patch area, I will focus my time on resources where
Update*is more often called, as those can be huge rabbit holes.MethodresourceUpdateMethod, snapshot tested, see https://docs.aws.amazon.com/apigateway/latest/api/patch-operations.html#UpdateMethod-Patch