Enable generic actions and enhance parity for DynamoDB API GW integration#7755
Merged
Enable generic actions and enhance parity for DynamoDB API GW integration#7755
Conversation
whummer
commented
Feb 26, 2023
| @@ -1,15 +1,10 @@ | |||
| import json | |||
Member
Author
There was a problem hiding this comment.
note: mostly cleanups / refactoring in this file (migrating logic into integrations.py), practically no functional changes.
4252317 to
f891973
Compare
f891973 to
73e1bcb
Compare
calvernaz
reviewed
Feb 26, 2023
calvernaz
approved these changes
Feb 26, 2023
Contributor
calvernaz
left a comment
There was a problem hiding this comment.
Nice cleanup 💯 and great to have more dynamo actions supported.
Couple of comments, nothing major
|
|
||
| response_template = response_templates.get(APPLICATION_JSON) | ||
| s3 = aws_stack.connect_to_service("s3") | ||
| uri = apply_request_parameters( |
Contributor
There was a problem hiding this comment.
in next iterations we can start moving from this function to the request parameters resolver
Member
Author
There was a problem hiding this comment.
Sounds great, looking forward to it! Do you have this in the pipeline @calvernaz ? Let's coordinate..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable generic actions and further enhance parity for DynamoDB API GW integration. Follow-up from #7753
So far, we had support for
dynamodb:action/PutItemanddynamodb:action/QueryDynamoDB integrations. While working on deploying a more complex AWS sample app against LocalStack, the requirements for further integration operations came up (incl.dynamodb:action/Scan, among others).Summary of changes:
dynamodb:action/*integration action that can be executed against DynamoDBPutItem,Scan)invocations.pyinto separate backend classes inintegrations.py/cc @calvernaz @bentsku @joe4dev