Enhance parity for API Gateway DynamoDB integrations#7753
Merged
Conversation
calvernaz
approved these changes
Feb 25, 2023
Contributor
calvernaz
left a comment
There was a problem hiding this comment.
Thanks for adding this, LGTM! 🚀
LocalStack integration with Pro 1 files - 2 1 suites - 2 1h 2m 38s ⏱️ - 43m 47s For more details on these failures, see this check. Results for commit 9eca2a5. ± Comparison against base commit 2e97ea1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance parity for API Gateway DynamoDB integrations. Follow-up from #7572
The PR also contains a few refactorings, starting to pull more of the service-specific integrations as classes into
integrations.pySummary of changes:
KinesisIntegrationandDynamoDBIntegration@patchdecorators for API GW patchesBadRequestExceptionfor incorrect use ofAWS_PROXYintegration (AWS parity)create_rest_api_with_integrationfixture that can used for DDB&Kinesis integration tests (and other integrations in the future)