Skip to content

✨ feat(chat): inline resend when editing last user message#14080

Merged
AmAzing129 merged 4 commits into
canaryfrom
feat/edit-message-inline-resend
Apr 23, 2026
Merged

✨ feat(chat): inline resend when editing last user message#14080
AmAzing129 merged 4 commits into
canaryfrom
feat/edit-message-inline-resend

Conversation

@AmAzing129

Copy link
Copy Markdown
Contributor

πŸ’» Change Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ‘· build
  • ⚑️ perf
  • βœ… test
  • πŸ“ docs
  • πŸ”¨ chore

πŸ”— Related Issue

N/A

πŸ”€ Description of Change

Make the edit confirm button in the user message edit modal reflect user intent:

  • When the edited message is the last user message AND the AI is not currently generating, the confirm button is labeled Send. Clicking it saves the edit and immediately triggers regenerateUserMessage so the AI produces a new reply in one step.
  • In all other cases (not the last user message, or a reply is still streaming / waiting), the button is labeled Save and only persists the text β€” avoiding destructive regeneration on mid-conversation edits and avoiding interference with in-flight generations.

Rationale: editing the last message is almost always a "re-ask" β€” merging save + regenerate removes a redundant extra click. Mid-conversation edits are typically just text fixes, where silently discarding subsequent messages would be unsafe.

Implementation lives entirely in src/features/Conversation/ChatItem/components/MessageContent/index.tsx:

  • Added subscriptions for role, isLastUserMessage (derived from displayMessages.findLast(role === 'user')), and messageStateSelectors.isAIGenerating.
  • Defensive role === 'user' guard ensures Send never shows on non-user content.
  • Reuses the existing regenerateUserMessage action (which already covers thread contexts via resendThreadMessage).
  • No changes to EditorModal (uses existing okText prop passthrough) and no new i18n keys (send and save already exist in common.ts).

πŸ§ͺ How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

Manual test scenarios:

  1. Send path: send a user message, wait for the AI reply to finish. Click edit on that user message β€” button reads Send. Modify the text and confirm β€” content updates and a new AI reply is generated in a new branch.
  2. Save path β€” not last: edit a user message that has subsequent messages after it. Button reads Save and only persists the text.
  3. Save path β€” AI generating: open the edit modal on the last user message while the AI is still streaming or waiting. Button reads Save.
  4. Reactivity: open the edit modal on the last user message while streaming (button: Save), keep it open, let the stream complete β€” button should flip to Send.
  5. Regression: assistant message editing (handled by EditState.tsx, not touched) continues to show OK.

Type check passes (bun run type-check).

πŸ“Έ Screenshots / Videos

UI change is limited to the label of the confirm button in the message edit modal (OK β†’ Save / Send).

Before After
Confirm button always shows OK β€” user must perform a separate regenerate action after editing the last message. Confirm button shows Send for the last user message (when AI is idle) and Save otherwise.

πŸ“ Additional Information

No breaking changes, no migration, no performance impact. The additional selectors are cheap (findLast single-pass on displayMessages, which is bounded by visible message count).

Change the edit modal confirm button to "Send" when the edited message is the last user message and AI is not currently generating β€” clicking it saves the edit and regenerates the reply in one step. Other cases keep a "Save" button so mid-conversation edits and in-flight generations are not disturbed.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@vercel

vercel Bot commented Apr 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Canceled Canceled Apr 23, 2026 7:34am

Request Review

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 67.14%. Comparing base (73860a9) to head (6cb018a).
⚠️ Report is 4 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff            @@
##           canary   #14080     +/-   ##
=========================================
  Coverage   67.14%   67.14%             
=========================================
  Files        2133     2133             
  Lines      182487   182487             
  Branches    18818    22316   +3498     
=========================================
  Hits       122533   122533             
  Misses      59829    59829             
  Partials      125      125             
Flag Coverage Ξ”
app 59.75% <ΓΈ> (ΓΈ)
database 92.23% <ΓΈ> (ΓΈ)
packages/agent-runtime 79.82% <ΓΈ> (ΓΈ)
packages/context-engine 83.10% <ΓΈ> (ΓΈ)
packages/conversation-flow 92.40% <ΓΈ> (ΓΈ)
packages/file-loaders 87.02% <ΓΈ> (ΓΈ)
packages/memory-user-memory 74.74% <ΓΈ> (ΓΈ)
packages/model-bank 99.89% <ΓΈ> (ΓΈ)
packages/model-runtime 84.07% <ΓΈ> (ΓΈ)
packages/prompts 70.14% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/utils 88.41% <ΓΈ> (ΓΈ)
packages/web-crawler 88.66% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 66.59% <ΓΈ> (ΓΈ)
Services 51.94% <ΓΈ> (ΓΈ)
Server 66.58% <ΓΈ> (ΓΈ)
Libs 52.50% <ΓΈ> (ΓΈ)
Utils 80.09% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 805c9124e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +80 to +84
const isLastUserMessage = useConversationStore(
(s) => s.displayMessages.findLast((m) => m.role === 'user')?.id === id,
);

const isAIGenerating = useConversationStore(messageStateSelectors.isAIGenerating);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid subscribing every message row to global send conditions

MessageContent is instantiated for every chat row, but these selectors run in each instance regardless of whether that row is being edited. On every store update (especially streaming token updates), each row executes displayMessages.findLast(...), making update cost scale roughly with message_countΒ², and each isAIGenerating flip also invalidates all rows. In long conversations this can noticeably degrade render performance; compute this only for the actively edited row (or derive last-user-id once at a higher level) instead of per-row subscriptions.

Useful? React with πŸ‘Β / πŸ‘Ž.

…cuit selector

Avoid running findLast on displayMessages for every chat row on every store update. Fold role / isLastUserMessage / isAIGenerating into a single selector that returns false when the row is not being edited, keeping streaming-token update cost O(1) per non-editing row instead of O(NΒ²) overall.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@AmAzing129

Copy link
Copy Markdown
Contributor Author

@codex review again

AmAzing129 and others added 2 commits April 23, 2026 15:14
Close the edit modal immediately instead of awaiting the DB round trip, and kick off regenerate in parallel with persistence. updateMessageContent already updates state optimistically before its await, so regenerate sees the latest content and can call switchMessageBranch right away β€” the previous assistant reply no longer lingers while the DB save is in flight.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
isAIGenerating is only true during AI runtime; it stays false during the initial sendMessage phase even though a request is already in flight for the same turn. Because that in-flight send is indexed under an optimistic tmp_* id, regenerateUserMessage on the persisted id could miss it and spawn a duplicate generation. Switch the gate to messageStateSelectors.isInputLoading, which covers sendMessage through AI completion (same state ChatInput already uses to block new sends).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@AmAzing129 AmAzing129 merged commit 53b4b4d into canary Apr 23, 2026
33 of 34 checks passed
@AmAzing129 AmAzing129 deleted the feat/edit-message-inline-resend branch April 23, 2026 07:47
arvinxx added a commit that referenced this pull request Apr 27, 2026
# πŸš€ LobeHub v2.1.53 (20260427)

**Release Date:** April 27, 2026
**Since v2.1.52:** 194 merged PRs Β· 17 contributors

> Introduce Heterogeneous Agent β€” Claude Code and Codex run as
first-class desktop runtimes, paired with a new Agent Signal package,
sharper desktop UX, and a wave of flagship model additions.

---

## ✨ Highlights

- **Introduce Heterogeneous Agent** β€” Claude Code and Codex run as
first-class desktop agents: subagent rendering, partial-message
streaming, multi-turn resume, terminal error surfacing, rich tool
inspectors, and runtime polish. (#14162, #13754, #14067, #14001, #13970,
#13942)
- **Screen capture & Quick Chat tray** β€” New desktop screen capture
overlay (macOS permission-gated) with Quick Chat tray and upload
pipeline improvements; chat input auto-focuses on overlay mount.
(#13818, #14097, #14105)
- **Desktop topic & tab UX** β€” Dedicated topic popup window with
cross-window sync, Cmd+W/Cmd+T tab shortcuts, TabBar polish, recent
working directories expanded to 20, and human approval notifications.
(#13957, #13983, #13972, #14036, #14092)
- **Git workflow built-in** β€” One-click pull/push from the branch chip,
ahead/behind badge, and submodule/worktree repo detection. (#14041,
#13980, #13978)
- **Agent Signal package** β€” New `@lobechat/agent-signal` runtime for
dynamic memory feedback signals, with OTel metrics and self-iteration in
Lab. (#14157, #14170, #14159, #14169, #14187)
- **New models** β€” Claude Opus 4.7 with `xhigh` effort tier, GPT-5.5,
DeepSeek V4 Flash/Pro with reasoning slider, Kimi K2.6, MiMo-V2.5/Pro,
gpt-image-2, Qwen3.6 Flash/Plus, and Pixverse-c1. (#13903, #14147,
#14114, #14004, #14089, #14039, #13923)
- **New providers** β€” OpenCode Zen, OpenCode Go, and Azure OpenAI Router
runtime. (#13943, #14064, #13823)
- **Mobile settings overhaul** β€” Full settings menu and responsive
profile layout for mobile. (#14019)

---

## πŸ—οΈ Heterogeneous Agent

- Claude Code runtime, working-directory awareness, and sidebar polish.
(#13970)
- CC subagent rendering with persistent streamed text; parallel-tool
orphan fix. (#14001, #13968, #14024)
- Per-step usage persisted to each step assistant message. (#13964)
- Per-phase workflow expand defaults; full-expand toggle with
three-level expansion. (#14171, #13906)
- Hetero-mode actions bar; tool inspector polish. (#13963, #14034,
#14030)
- Codex desktop integration with rich tool rendering and devtools
preview. (#14067, #14100)
- Codex terminal error surfacing and CLI output tracing. (#14166)
- Tighten `isCanUseVision` default and add aggregator fallback. (#14172)
- Persist `ccSessionId` in topic metadata for CC multi-turn resume.
(#13902)
- CC account card, topic filter, and integration polish. (#13955,
#13942, #13950)
- Token-level deltas streamed via `--include-partial-messages`. (#13929)

---

## 🧠 Agent Signal & Self-Iteration

- New `@lobechat/agent-signal` package with dynamic feedback signals.
(#14157)
- AgentSignalRuntime wired through agent-tracing and observability-otel
metrics. (#14170, #14159)
- Self-iteration feature flag added to Lab; front-side flag check.
(#14169, #14186)
- Signal policy for receiving memory feedback dynamically. (#14187)

---

## πŸ’¬ Conversation

- Queue follow-up sends during running CC turns. (#14179)
- Persist per-topic chat scroll position; pin user message + fold long
messages. (#14191, #14056)
- Inline resend when editing last user message. (#14080)
- Disable first-block markdown streaming to prevent flicker. (#14193,
#13904)
- Prevent Markdown stream replay when vlist remounts streaming items.
(#14086)
- Stop repinning after manual scroll; unify scroll-to-user + spacer
hooks. (#14099, #14132)

---

## πŸ“± Platforms & Integrations

### Desktop / Electron

- Screen capture overlay, Quick Chat tray, and upload pipeline
improvements. (#13818)
- macOS permission gate for screen capture; auto-focus chat panel input.
(#14097, #14105)
- Dedicated topic popup window with cross-window sync. (#13957)
- TabBar polish: `+` button for new topic, dark theme blend, close icon
by default. (#13972, #14203, #13973)
- Recent working directories expanded from 5 to 20; submodule/worktree
repo detection. (#14036, #13978)
- Cmd+W / Cmd+T tab shortcuts and global shortcut consolidation.
(#13983, #13880)
- Linux icon configuration; human approval desktop notifications.
(#14042, #14092)

### Git Workflow

- One-click pull/push from branch chip; ahead/behind badge with
refactored GitCtr. (#14041, #13980)

### Mobile

- Full settings menu and responsive profile layout. (#14019)
- Agent route added to mobile router; mobile agent topic route
registered. (#14103, #14158)
- Session list skeleton row layout corrected. (#14040)

### Bot / Messaging

- DM strategy support; bot emoji and markdown render optimization.
(#14201, #14091, #14140)
- Slack webhook fix; bot platform setup guide reference. (#14052,
#14121)

---

## πŸ€– Models & Providers

### New models

- **Claude Opus 4.7** with `xhigh` effort tier; strip temperature/top_p.
(#13903, #13909)
- **GPT-5.5**. (#14147)
- **DeepSeek V4** Flash/Pro cards with reasoning slider; cache-hit and
Pro discount pricing. (#14114, #14209, #14196, #14131)
- **Kimi K2.6** model with LobeHub-hosted card. (#14004, #14006)
- **MiMo-V2.5 / V2.5-Pro**. (#14089)
- **gpt-image-2**, **Qwen3.6 Flash/Plus**, **Pixverse-c1**. (#14039,
#13923)

### New providers

- **OpenCode Zen** and **OpenCode Go** with env-var support. (#13943,
#14064)
- **Azure OpenAI Router** runtime support. (#13823)
- Model alias mapping for image and video runtimes. (#13896)
- Seedance video models migrated to Dreamina. (#14144)

### Runtime reliability

- Sanitize invalid tool_call arguments to unbreak strict providers.
(#14033)
- Tolerate null `function.name` in streaming tool_call deltas. (#14139)
- Preserve Gemini 3 `thoughtSignature` in `call_tools_batch`
normalization. (#14032)
- Downgrade `image_url` parts when target model lacks vision. (#14029)
- Preserve Cloudflare provider error context. (#14136)
- Use `safety_identifier` for OpenAI Responses API. (#14148)
- Unwrap underlying PG error in `formatErrorEventData`. (#14038)

---

## πŸ–₯️ User Experience

- **Onboarding** β€” Preset agent naming suggestions, structured hunk ops
for `updateDocument`, persona analytics snapshot, footer promotion
pipeline, wrap-up button. (#13931, #13989, #13930, #13853, #13934)
- **Document workflow** β€” Agent documents promoted as primary workspace
panel; history management and compare workflow; web-crawl docs
associated with agent documents. (#13924, #13725, #13893)
- **cmdk** β€” Agent identity surfaced on topic search results;
topic/message search scoped to current agent. (#14204, #13960)
- **Floating chat panel** and workspace improvements. (#13887)
- **Topic completion status** with dropdown action and filter. (#14005)

---

## πŸ”§ Tooling

- Redis-backed feature flag provider for runtime config. (#14098)
- Vite upgraded to 8.0.0 with Rolldown strict execution order. (#12720,
#14058)
- `@lobechat/model-bank` automated npm release with provenance. (#14015,
#14017, #14018)
- Skill activation fallback when `activateTools` cannot find identifier.
(#14010)
- Cron tool: timezone and existing jobs injected into system prompt;
clarified `lobe-gtd` and `lobe-cron` descriptions. (#14012, #14013)

---

## πŸ”’ Security & Reliability

- **Security:** uuid bumped to v14 (advisory). (#14083)
- **Security:** validate avatar URL and scope old-avatar deletion to
owner. (#13982)
- **Security:** clear OIDC sessions on better-auth signout; return 401
(not 500) for expired OIDC JWT. (#13916, #14014)
- **Reliability:** scope pending-approval check to current assistant
turn. (#14182)
- **Reliability:** sanitize heterogeneous-agent attachment cache
filenames. (#13937)
- **Reliability:** reduce subagent task status error noise. (#14026)

---

## πŸ‘₯ Contributors

Huge thanks to **17 contributors** who shipped **194 merged PRs** this
week.

@hardy Β· @shaun0927 Β· @hezhijie0327 Β· @sxjeru Β· @arvinxx Β· @Innei Β·
@tjx666 Β· @lijian Β· @neko Β· @rdmclin2 Β· @AmAzing129 Β· @sudongyuer Β·
@CanisMinor Β· @rivertwilight

Plus @lobehubbot and renovate[bot] for maintenance.

---

**Full Changelog**:
v2.1.52...v2.1.53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant