Skip to content

✨ feat: improve error UI and error handling across chat and image generation#13302

Merged
tjx666 merged 11 commits into
canaryfrom
feat/hide-provider-settings
Mar 26, 2026
Merged

✨ feat: improve error UI and error handling across chat and image generation#13302
tjx666 merged 11 commits into
canaryfrom
feat/hide-provider-settings

Conversation

@tjx666

@tjx666 tjx666 commented Mar 26, 2026

Copy link
Copy Markdown
Member

πŸ’» Change Type

  • ✨ feat
  • πŸ› fix
  • πŸ’„ style

πŸ”— Related Issue

Fixes https://linear.app/lobehub/issue/LOBE-5592/429-ι”™θ――δΏ‘ζ―δΌ˜εŒ–
Fixes https://linear.app/lobehub/issue/LOBE-6137/fal-422

πŸ”€ Description of Change

  • Add ExceededContextWindowError component with compact context button for exceeded context window errors
  • Skip fallback retry for ExceededContextWindow errors in router-runtime (400 errors shouldn't retry)
  • Classify ExceededContextWindow errors in bedrock provider
  • Improve QuotaLimitReachedCloud error message to suggest switching models
  • Remove shimmer animation from image/video generation error items (was incorrectly applied to error state)
  • Detect content policy violations in image generation (fal 422 + volcengine sensitive content) and show clean error message
  • Add traceId error i18n keys for user-friendly unknown error display
  • Format token numbers with K/M suffixes for readability
  • Hide provider settings entry for cloud users unless in dev mode
  • Remove debug console.info in parseFileContent

πŸ§ͺ How to Test

  • Tested locally
  • No tests needed

πŸ“ Additional Information

  • ExceededContextWindow errors now short-circuit in runWithFallback instead of trying all channels
  • Content policy detection in categorizeError covers volcengine InputTextSensitiveContentDetected, fal content_policy_violation, and generic patterns

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @tjx666, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@vercel

vercel Bot commented Mar 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Mar 26, 2026 11:58am

Request Review

@lobehubbot

Copy link
Copy Markdown
Member

@sxjeru @ONLY-yours - This PR improves error UI and error handling across chat and image generation, including provider changes for bedrock/fal and conversation error components. Please coordinate on review.

@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.81633% with 29 lines in your changes missing coverage. Please review.
βœ… Project coverage is 66.89%. Comparing base (a1e91ab) to head (101479f).
⚠️ Report is 19 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #13302      +/-   ##
==========================================
- Coverage   66.91%   66.89%   -0.03%     
==========================================
  Files        1867     1868       +1     
  Lines      147855   147955     +100     
  Branches    16904    14199    -2705     
==========================================
+ Hits        98942    98968      +26     
- Misses      48802    48875      +73     
- Partials      111      112       +1     
Flag Coverage Ξ”
app 58.13% <29.16%> (-0.03%) ⬇️
database 97.89% <ΓΈ> (ΓΈ)
packages/agent-runtime 89.60% <ΓΈ> (ΓΈ)
packages/context-engine 83.59% <ΓΈ> (ΓΈ)
packages/conversation-flow 92.36% <ΓΈ> (ΓΈ)
packages/file-loaders 87.02% <ΓΈ> (ΓΈ)
packages/memory-user-memory 66.68% <ΓΈ> (ΓΈ)
packages/model-bank 99.85% <ΓΈ> (ΓΈ)
packages/model-runtime 84.48% <52.00%> (-0.06%) ⬇️
packages/prompts 74.60% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/utils 90.41% <ΓΈ> (ΓΈ)
packages/web-crawler 88.82% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 66.08% <66.66%> (+<0.01%) ⬆️
Services 49.58% <ΓΈ> (ΓΈ)
Server 68.11% <0.00%> (-0.03%) ⬇️
Libs 43.20% <ΓΈ> (ΓΈ)
Utils 91.01% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47713a5865

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +40 to +42
await deleteMessage(id);
await chatState.executeCompression(context, '');
await regenerateAssistantMessage(id);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve assistant context before deleting error message

Calling deleteMessage(id) before regenerateAssistantMessage(id) makes regeneration a no-op, because regeneration resolves the assistant by ID from current displayMessages and returns when it is missing. In this flow, the message is optimistically removed first, so after compaction the failed reply is never retried even though the UI action implies β€œcompact and continue”.

Useful? React with πŸ‘Β / πŸ‘Ž.

Comment on lines +33 to +37
const context = {
agentId: chatState.activeAgentId,
groupId: chatState.activeGroupId,
topicId,
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include full conversation scope when compacting context

The compaction context here only includes agentId/groupId/topicId, but executeCompression routes by messageMapKey(context), which requires thread/group-agent fields (for example threadId, scope, subAgentId) to target the correct message stream. In thread or group-agent conversations, this can compact the wrong conversation (main/group) and leave the over-limit branch unchanged.

Useful? React with πŸ‘Β / πŸ‘Ž.

@tjx666 tjx666 merged commit d2a16d0 into canary Mar 26, 2026
33 of 34 checks passed
@tjx666 tjx666 deleted the feat/hide-provider-settings branch March 26, 2026 12:09
@lobehubbot

Copy link
Copy Markdown
Member

❀️ Great PR @tjx666 ❀️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

ONLY-yours added a commit that referenced this pull request Mar 27, 2026
# πŸš€ release: 20260326

This release includes **91 commits**. Key updates are below.


- **Agent can now execute background tasks** β€” Agents can perform
long-running operations without blocking your conversation.
[#13289](#13289)
- **Better error messages** β€” Redesigned error UI across chat and image
generation with clearer explanations and recovery options.
[#13302](#13302)
- **Smoother topic switching** β€” No more full page reloads when
switching topics while an agent is responding.
[#13309](#13309)
- **Faster image uploads** β€” Large images are now automatically
compressed to 1920px before upload, reducing wait times.
[#13224](#13224)
- **Improved knowledge base** β€” Documents are now properly parsed before
chunking, improving retrieval accuracy.
[#13221](#13221)

### Bot Platform

- **WeChat Bot support** β€” You can now connect LobeChat to WeChat, in
addition to Discord.
[#13191](#13191)
- **Richer bot responses** β€” Bots now support custom markdown rendering
and context injection.
[#13294](#13294)
- **New bot commands** β€” Added `/new` to start fresh conversations and
`/stop` to halt generation.
[#13194](#13194)
- **Discord stability fixes** β€” Fixed thread creation issues and Redis
connection drops.
[#13228](#13228)
[#13205](#13205)

### Models & Providers

- **GLM-5** is now available in the LobeHub model list.
[#13189](#13189)
- **Coding Plan providers** β€” Added support for code planning assistant
providers. [#13203](#13203)
- **Tencent Hunyuan 3.0 ImageGen** β€” New image generation model from
Tencent. [#13166](#13166)
- **Gemini content handling** β€” Better handling when Gemini blocks
content due to safety filters.
[#13270](#13270)
- **Claude token limits fixed** β€” Corrected max window tokens for
Anthropic Claude models.
[#13206](#13206)

### Skills & Tools

- **Auto credential injection** β€” Skills can now automatically request
and use required credentials.
[#13124](#13124)
- **Smarter tool permissions** β€” Built-in tools skip confirmation for
safe paths like `/tmp`.
[#13232](#13232)
- **Model switcher improvements** β€” Quick access to provider settings
and visual highlight for default model.
[#13220](#13220)

### Memory

- **Bulk delete memories** β€” You can now delete all memory entries at
once. [#13161](#13161)
- **Per-agent memory control** β€” Memory injection now respects
individual agent settings.
[#13265](#13265)

### Desktop App

- **Gateway connection** β€” Desktop app can now connect to LobeHub
Gateway for enhanced features.
[#13234](#13234)
- **Connection status indicator** β€” See gateway connection status in the
titlebar. [#13260](#13260)
- **Settings persistence** β€” Gateway toggle state now persists across
app restarts. [#13300](#13300)

### CLI

- **API key authentication** β€” CLI now supports API key auth for
programmatic access.
[#13190](#13190)
- **Shell completion** β€” Tab completion for bash/zsh/fish shells.
[#13164](#13164)
- **Man pages** β€” Built-in manual pages for CLI commands.
[#13200](#13200)

### Security

- **XSS protection** β€” Sanitized search result image titles to prevent
script injection.
[#13303](#13303)
- **Workflow hardening** β€” Fixed potential shell injection in release
automation. [#13319](#13319)
- **Dependency update** β€” Updated nodemailer to address security
advisory. [#13326](#13326)

### Bug Fixes

- Fixed skill page not redirecting correctly after import.
[#13255](#13255)
[#13261](#13261)
- Fixed token counting in group chats.
[#13247](#13247)
- Fixed editor not resetting when switching to empty pages.
[#13229](#13229)
- Fixed manual tool toggle not working.
[#13218](#13218)
- Fixed Search1API response parsing.
[#13207](#13207)
[#13208](#13208)
- Fixed mobile topic menus rendering issues.
[#12477](#12477)
- Fixed history count calculation for accurate context.
[#13051](#13051)
- Added missing Turkish translations.
[#13196](#13196)

### Credits

Huge thanks to these contributors:

@bakiburakogun @hardy-one @Zhouguanyang @sxjeru @hezhijie0327 @arvinxx
@cy948 @CanisMinor @Innei @lijian @lobehubbot @neko @rdmclin2
@rivertwilight @tjx666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants