fix: add discord redisClient lost problem#13205
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@nekomeowww @ONLY-yours - This is a backend API fix for the agent Discord gateway (redisClient issue). Please take a look. |
|
❤️ Great PR @rdmclin2 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e17a97fa1c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return discord.clientFactory.createClient(config, { appUrl: process.env.APP_URL }); | ||
| return discord.clientFactory.createClient(config, { | ||
| appUrl: process.env.APP_URL, | ||
| redisClient: getAgentRuntimeRedisClient() as any, |
There was a problem hiding this comment.
Route cron-started Discord bots through the Redis proxy
Passing getAgentRuntimeRedisClient() directly here reintroduces the listener leak that src/server/services/bot/BotMessageRouter.ts:220-252 already documents and works around: every DiscordGatewayClient.start() call builds createIoRedisState({ client }) in src/server/services/bot/platforms/discord/client.ts:70-75, which adds another error listener to the shared ioredis instance. In a workspace with roughly 10 Discord bots, or after enough cron runs on a warm worker, this route will start emitting MaxListenersExceededWarning and keep stale listeners alive because the Discord client never disconnects that shared state adapter.
Useful? React with 👍 / 👎.
| return discord.clientFactory.createClient(config, { appUrl: process.env.APP_URL }); | ||
| return discord.clientFactory.createClient(config, { | ||
| appUrl: process.env.APP_URL, | ||
| redisClient: getAgentRuntimeRedisClient() as any, |
There was a problem hiding this comment.
Namespace Redis-backed Discord state per application
This path now enables Redis-backed Chat state for every cron-started Discord bot, but unlike src/server/services/bot/BotMessageRouter.ts:263-269 it never gives each bot its own keyPrefix. Our Discord thread IDs are only discord:guildId:channelId[:threadId] (src/server/services/bot/AgentBridgeService.ts:776-779), so if two Discord apps are installed in the same channel they will now read and write the same Redis subscription/lock/cache entries and can suppress or serialize each other’s work. Before this change those cron-started bots were isolated in memory.
Useful? React with 👍 / 👎.
# 🚀 release: 20260326 This release includes **91 commits**. Key updates are below. - **Agent can now execute background tasks** — Agents can perform long-running operations without blocking your conversation. [#13289](#13289) - **Better error messages** — Redesigned error UI across chat and image generation with clearer explanations and recovery options. [#13302](#13302) - **Smoother topic switching** — No more full page reloads when switching topics while an agent is responding. [#13309](#13309) - **Faster image uploads** — Large images are now automatically compressed to 1920px before upload, reducing wait times. [#13224](#13224) - **Improved knowledge base** — Documents are now properly parsed before chunking, improving retrieval accuracy. [#13221](#13221) ### Bot Platform - **WeChat Bot support** — You can now connect LobeChat to WeChat, in addition to Discord. [#13191](#13191) - **Richer bot responses** — Bots now support custom markdown rendering and context injection. [#13294](#13294) - **New bot commands** — Added `/new` to start fresh conversations and `/stop` to halt generation. [#13194](#13194) - **Discord stability fixes** — Fixed thread creation issues and Redis connection drops. [#13228](#13228) [#13205](#13205) ### Models & Providers - **GLM-5** is now available in the LobeHub model list. [#13189](#13189) - **Coding Plan providers** — Added support for code planning assistant providers. [#13203](#13203) - **Tencent Hunyuan 3.0 ImageGen** — New image generation model from Tencent. [#13166](#13166) - **Gemini content handling** — Better handling when Gemini blocks content due to safety filters. [#13270](#13270) - **Claude token limits fixed** — Corrected max window tokens for Anthropic Claude models. [#13206](#13206) ### Skills & Tools - **Auto credential injection** — Skills can now automatically request and use required credentials. [#13124](#13124) - **Smarter tool permissions** — Built-in tools skip confirmation for safe paths like `/tmp`. [#13232](#13232) - **Model switcher improvements** — Quick access to provider settings and visual highlight for default model. [#13220](#13220) ### Memory - **Bulk delete memories** — You can now delete all memory entries at once. [#13161](#13161) - **Per-agent memory control** — Memory injection now respects individual agent settings. [#13265](#13265) ### Desktop App - **Gateway connection** — Desktop app can now connect to LobeHub Gateway for enhanced features. [#13234](#13234) - **Connection status indicator** — See gateway connection status in the titlebar. [#13260](#13260) - **Settings persistence** — Gateway toggle state now persists across app restarts. [#13300](#13300) ### CLI - **API key authentication** — CLI now supports API key auth for programmatic access. [#13190](#13190) - **Shell completion** — Tab completion for bash/zsh/fish shells. [#13164](#13164) - **Man pages** — Built-in manual pages for CLI commands. [#13200](#13200) ### Security - **XSS protection** — Sanitized search result image titles to prevent script injection. [#13303](#13303) - **Workflow hardening** — Fixed potential shell injection in release automation. [#13319](#13319) - **Dependency update** — Updated nodemailer to address security advisory. [#13326](#13326) ### Bug Fixes - Fixed skill page not redirecting correctly after import. [#13255](#13255) [#13261](#13261) - Fixed token counting in group chats. [#13247](#13247) - Fixed editor not resetting when switching to empty pages. [#13229](#13229) - Fixed manual tool toggle not working. [#13218](#13218) - Fixed Search1API response parsing. [#13207](#13207) [#13208](#13208) - Fixed mobile topic menus rendering issues. [#12477](#12477) - Fixed history count calculation for accurate context. [#13051](#13051) - Added missing Turkish translations. [#13196](#13196) ### Credits Huge thanks to these contributors: @bakiburakogun @hardy-one @Zhouguanyang @sxjeru @hezhijie0327 @arvinxx @cy948 @CanisMinor @Innei @lijian @lobehubbot @neko @rdmclin2 @rivertwilight @tjx666
💻 Change Type
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information