π style: move plugin store button outside scroll container#11728
π style: move plugin store button outside scroll container#11728
Conversation
Move the plugin store entry button to a fixed position at the bottom of the dropdown, outside the scrollable area for better UX.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideRefactors the agent tool dropdown so the plugin store button is rendered in a fixed footer outside the scrollable menu area, adjusting layout and styles to support a flex-based dropdown container. Flow diagram for updated agent tool dropdown layout and plugin store footerflowchart TD
AgentTool[AgentTool component]
ActionDropdownNode[ActionDropdown with popupRender]
DropdownFlex[Flexbox dropdown container]
Header[Header with Segmented tabs]
Scroller[Scrollable area with menu items]
MenuItems["Tool menu items (builtin and plugins)"]
Footer[Fixed Flexbox footer]
StoreIcon[Store icon]
StoreLabel[Plugin store label]
ArrowRightIcon[ArrowRight icon]
SkillStoreModal[createSkillStoreModal handler]
AgentTool --> ActionDropdownNode
ActionDropdownNode --> DropdownFlex
DropdownFlex --> Header
DropdownFlex --> Scroller
Scroller --> MenuItems
DropdownFlex --> Footer
Footer --> StoreIcon
Footer --> StoreLabel
Footer --> ArrowRightIcon
Footer --> SkillStoreModal
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new footer element is a clickable Flexbox without button semantics; consider using a real button or adding
role="button"and keyboard handlers (Enter/Space) to preserve accessibility and keyboard navigation parity with the previous menu item. - Youβre now mixing layout/styling concerns between
createStaticStylesand inline styles on the dropdown and scroller; consolidating themaxHeight,flex, padding, and border styles into the CSS-in-JS styles would make the layout easier to maintain and tweak.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new footer element is a clickable Flexbox without button semantics; consider using a real button or adding `role="button"` and keyboard handlers (Enter/Space) to preserve accessibility and keyboard navigation parity with the previous menu item.
- Youβre now mixing layout/styling concerns between `createStaticStyles` and inline styles on the dropdown and scroller; consolidating the `maxHeight`, `flex`, padding, and border styles into the CSS-in-JS styles would make the layout easier to maintain and tweak.Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d076219232
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Flexbox | ||
| align="center" | ||
| gap={8} | ||
| horizontal | ||
| onClick={() => createSkillStoreModal()} |
There was a problem hiding this comment.
Keep the store entry keyboard-accessible
This store entry is now rendered as a plain Flexbox with an onClick, so it is no longer focusable or selectable via keyboard (no tabIndex/role/key handlers) the way the previous menu item was. That means keyboard and assistiveβtech users canβt open the plugin store from this dropdown. Consider using a real menu item or a button element (or add role="button", tabIndex={0}, and key handling) to preserve accessibility.
Useful? React with πΒ / π.
Codecov Reportβ
All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## next #11728 +/- ##
===========================================
- Coverage 85.74% 74.27% -11.47%
===========================================
Files 378 1160 +782
Lines 26334 92298 +65964
Branches 4516 10832 +6316
===========================================
+ Hits 22579 68556 +45977
- Misses 3665 23652 +19987
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
|
β€οΈ Great PR @Innei β€οΈ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
## [Version 2.0.0-next.347](v2.0.0-next.346...v2.0.0-next.347) <sup>Released on **2026-01-23**</sup> #### π Bug Fixes - **misc**: Add advace config back in agent/group profiles. #### π Styles - **misc**: Move plugin store button outside scroll container. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Add advace config back in agent/group profiles, closes [#11727](#11727) ([403175f](403175f)) #### Styles * **misc**: Move plugin store button outside scroll container, closes [#11728](#11728) ([c484d1a](c484d1a)) </details> <div align="right"> [](#readme-top) </div>
|
π This PR is included in version 2.0.0-next.347 π The release is available on: Your semantic-release bot π¦π |
### [Version 1.153.1](v1.153.0...v1.153.1) <sup>Released on **2026-01-23**</sup> #### π Bug Fixes - **misc**: Add advace config back in agent/group profiles, fixed the group topic copy not right. #### π Styles - **misc**: Move plugin store button outside scroll container. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Add advace config back in agent/group profiles, closes [lobehub#11727](https://github.com/jaworldwideorg/OneJA-Bot/issues/11727) ([403175f](403175f)) * **misc**: Fixed the group topic copy not right, closes [lobehub#11730](https://github.com/jaworldwideorg/OneJA-Bot/issues/11730) ([282c1fb](282c1fb)) #### Styles * **misc**: Move plugin store button outside scroll container, closes [lobehub#11728](https://github.com/jaworldwideorg/OneJA-Bot/issues/11728) ([c484d1a](c484d1a)) </details> <div align="right"> [](#readme-top) </div>
π» Change Type
π Related Issue
π Description of Change
Move the plugin store entry button to a fixed position at the bottom of the dropdown, outside the scrollable area.
Changes:
flex: 1to fill available spaceπ§ͺ How to Test
πΈ Screenshots / Videos
π Additional Information
N/A
Summary by Sourcery
Adjust agent tool dropdown layout to keep the plugin store entry fixed at the bottom outside the scrollable list.
Enhancements: