π fix: add advace config back in agent/group profiles#11727
Merged
ONLY-yours merged 2 commits intonextfrom Jan 23, 2026
Merged
π fix: add advace config back in agent/group profiles#11727ONLY-yours merged 2 commits intonextfrom
ONLY-yours merged 2 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Reviewer's GuideReintroduces and standardizes the advanced settings UI for both agent and group profiles by adding a reusable modal-based AgentSettings layout, wiring it to existing stores, and fixing small layout issues in the opening questions form. Sequence diagram for opening advanced settings from agent profilesequenceDiagram
actor User
participant ProfileEditor
participant AgentStore
participant AgentSettingsModal
participant AgentSettingsContent
participant AgentSettingsFeature
User->>ProfileEditor: clickAdvancedSettingsButton
ProfileEditor->>AgentStore: setState(showAgentSetting=true)
AgentStore-->>AgentSettingsModal: showAgentSetting=true
AgentSettingsModal->>AgentSettingsContent: render
AgentSettingsContent->>AgentStore: get activeAgentId
AgentSettingsContent->>AgentStore: get currentAgentConfig
AgentSettingsContent->>AgentStore: get currentAgentMeta
User->>AgentSettingsFeature: editConfigAndMeta
AgentSettingsFeature->>AgentSettingsContent: onConfigChange(config)
AgentSettingsContent->>AgentStore: optimisticUpdateAgentConfig(agentId, config)
AgentSettingsFeature->>AgentSettingsContent: onMetaChange(meta)
AgentSettingsContent->>AgentStore: optimisticUpdateAgentMeta(agentId, meta)
User->>AgentSettingsModal: close
AgentSettingsModal->>AgentStore: setState(showAgentSetting=false)
Sequence diagram for opening advanced settings from group profilesequenceDiagram
actor User
participant GroupProfile
participant AgentSettingsModal
participant AgentSettingsContent
participant AgentGroupStore
participant AgentSettingsFeature
User->>GroupProfile: clickAdvancedSettingsButton
GroupProfile->>GroupProfile: setShowAgentSetting(true)
GroupProfile-->>AgentSettingsModal: open=true
AgentSettingsModal->>AgentSettingsContent: render
AgentSettingsContent->>AgentGroupStore: get activeGroupId
AgentSettingsContent->>AgentGroupStore: get currentGroup
User->>AgentSettingsFeature: editOpeningSettings
AgentSettingsFeature->>AgentSettingsContent: onConfigChange(config)
AgentSettingsContent->>AgentGroupStore: updateGroupConfig(groupConfig)
AgentSettingsFeature->>AgentSettingsContent: onMetaChange(meta)
AgentSettingsContent->>AgentGroupStore: updateGroup(groupId, meta)
User->>AgentSettingsModal: close
AgentSettingsModal->>GroupProfile: onCancel
GroupProfile->>GroupProfile: setShowAgentSetting(false)
Class diagram for new AgentSettings components in agent and group profilesclassDiagram
class ProfileEditor {
+ProfileEditor()
}
class GroupProfile {
+GroupProfile()
}
class AgentSettingsModalAgent {
+AgentSettingsModalAgent()
+render()
}
class AgentSettingsModalGroup {
+AgentSettingsModalGroup(open)
+onCancel()
+render()
}
class AgentSettingsContentAgent {
-agentId
-isInbox
-config
-meta
-tab
+AgentSettingsContentAgent()
+updateAgentConfig(config)
+updateAgentMeta(meta)
}
class AgentSettingsContentGroup {
-groupId
-currentGroup
-tab
+AgentSettingsContentGroup()
+updateGroupConfig(config)
+updateGroupMeta(meta)
}
class AgentStore {
+activeAgentId
+showAgentSetting
+currentAgentConfig
+currentAgentMeta
+optimisticUpdateAgentConfig(agentId, config)
+optimisticUpdateAgentMeta(agentId, meta)
+setState(partialState)
}
class AgentGroupStore {
+activeGroupId
+currentGroup
+updateGroupConfig(groupConfig)
+updateGroup(groupId, meta)
}
class AgentSettingsFeature {
+AgentSettingsFeature(config, id, loading, meta, onConfigChange, onMetaChange, tab)
}
class MenuComponent {
+MenuComponent(items, onClick, selectable, selectedKeys)
}
ProfileEditor --> AgentSettingsModalAgent : uses
GroupProfile --> AgentSettingsModalGroup : uses
AgentSettingsModalAgent --> AgentSettingsContentAgent : renders
AgentSettingsModalGroup --> AgentSettingsContentGroup : renders
AgentSettingsContentAgent --> AgentStore : readsAndWrites
AgentSettingsContentGroup --> AgentGroupStore : readsAndWrites
AgentSettingsContentAgent --> AgentSettingsFeature : composes
AgentSettingsContentGroup --> AgentSettingsFeature : composes
AgentSettingsContentAgent --> MenuComponent : uses
AgentSettingsContentGroup --> MenuComponent : uses
AgentStore <.. ProfileEditor : selectorUsage
AgentGroupStore <.. GroupProfile : selectorUsage
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
TestGru AssignmentSummary
Tip You can |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The agent and group
AgentSettingsmodals share nearly identical modal configuration (height, width, body styles); consider extracting a shared wrapper component or config to avoid duplication and keep them in sync. - In the group
AgentSettings/Content,tabis stored inuseStatebut never updated; if the tab is always fixed toOpening, you can replace it with a constant to simplify the component. - The agent profile uses a global
showAgentSettingflag in the store while the group profile uses localuseStatefor the same concern; consider standardizing how the advanced settings modal visibility is managed for consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The agent and group `AgentSettings` modals share nearly identical modal configuration (height, width, body styles); consider extracting a shared wrapper component or config to avoid duplication and keep them in sync.
- In the group `AgentSettings/Content`, `tab` is stored in `useState` but never updated; if the tab is always fixed to `Opening`, you can replace it with a constant to simplify the component.
- The agent profile uses a global `showAgentSetting` flag in the store while the group profile uses local `useState` for the same concern; consider standardizing how the advanced settings modal visibility is managed for consistency.Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88463fef94
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+126
to
+130
| <Settings | ||
| config={agentConfig} | ||
| id={groupId} | ||
| loading={false} | ||
| meta={agentMeta} |
There was a problem hiding this comment.
Avoid agent-store loading gate for group settings
The group profile now renders the shared AgentSettings component, but that componentβs content is gated by useAgentStore(agentSelectors.isAgentConfigLoading) (see src/features/AgentSetting/AgentSettingsContent.tsx). In a group profile session where activeAgentId is unset (fresh load or after clearing agent state), isAgentConfigLoading stays true and the modal will only show the skeleton even though agentConfig/agentMeta are provided here. The loading={false} you pass is ignored by AgentSettingsContent, so users canβt reach Opening settings unless an unrelated agent is active.
Useful? React with πΒ / π.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #11727 +/- ##
=======================================
Coverage 74.18% 74.18%
=======================================
Files 1194 1194
Lines 95149 95149
Branches 13006 13006
=======================================
Hits 70587 70587
Misses 24472 24472
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
Member
|
β€οΈ Great PR @ONLY-yours β€οΈ The growth of the project is inseparable from user feedback and contributions. Thanks for your contribution! If you are interested in the LobeHub developer community, please join our Discord and then DM @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are discussing lobe-chat development and sharing AI newsletters from around the world.
Original Contentβ€οΈ Great PR @ONLY-yours β€οΈ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
lobehubbot
pushed a commit
that referenced
this pull request
Jan 23, 2026
## [Version 2.0.0-next.347](v2.0.0-next.346...v2.0.0-next.347) <sup>Released on **2026-01-23**</sup> #### π Bug Fixes - **misc**: Add advace config back in agent/group profiles. #### π Styles - **misc**: Move plugin store button outside scroll container. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Add advace config back in agent/group profiles, closes [#11727](#11727) ([403175f](403175f)) #### Styles * **misc**: Move plugin store button outside scroll container, closes [#11728](#11728) ([c484d1a](c484d1a)) </details> <div align="right"> [](#readme-top) </div>
Member
|
π This PR is included in version 2.0.0-next.347 π The release is available on: Your semantic-release bot π¦π |
JamieStivala
pushed a commit
to jaworldwideorg/OneJA-Bot
that referenced
this pull request
Jan 23, 2026
### [Version 1.153.1](v1.153.0...v1.153.1) <sup>Released on **2026-01-23**</sup> #### π Bug Fixes - **misc**: Add advace config back in agent/group profiles, fixed the group topic copy not right. #### π Styles - **misc**: Move plugin store button outside scroll container. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Add advace config back in agent/group profiles, closes [lobehub#11727](https://github.com/jaworldwideorg/OneJA-Bot/issues/11727) ([403175f](403175f)) * **misc**: Fixed the group topic copy not right, closes [lobehub#11730](https://github.com/jaworldwideorg/OneJA-Bot/issues/11730) ([282c1fb](282c1fb)) #### Styles * **misc**: Move plugin store button outside scroll container, closes [lobehub#11728](https://github.com/jaworldwideorg/OneJA-Bot/issues/11728) ([c484d1a](c484d1a)) </details> <div align="right"> [](#readme-top) </div>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π» Change Type
fix: LOBE-4025
π Related Issue
π Description of Change
π§ͺ How to Test
πΈ Screenshots / Videos
π Additional Information
Summary by Sourcery
Restore and enhance advanced configuration access for both individual agents and agent groups via a dedicated settings modal from their profile editors.
New Features:
Bug Fixes:
Enhancements: