[libc++] Fix name of is_always_lock_free test which was never being run by ldionne · Pull Request #106077 · llvm/llvm-project

ldionne · 2024-08-26T14:11:30Z

No description provided.

llvmbot · 2024-08-26T14:12:12Z

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/106077.diff

1 Files Affected:

(renamed) libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp ()

diff --git a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.cpp b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
similarity index 100%
rename from libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.cpp
rename to libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp

tru · 2024-09-01T08:19:36Z

Seems like this PR caused tests to fail. Can you have a look @ldionne

tru · 2024-09-10T14:45:46Z

ping

tru · 2024-09-11T08:21:18Z

@philnik777 you approved it - but the tests are failing - I did re-run them and it still failed. Would it still be safe to merge this?

philnik777 · 2024-09-11T08:52:39Z

@philnik777 you approved it - but the tests are failing - I did re-run them and it still failed. Would it still be safe to merge this?

Not as-is. We need to suppress the diagnostic that causes the test to fail, but that's a minor change.

ldionne · 2024-09-17T14:21:44Z

Sorry, I dropped the ball on this cause I was absorbed by the modules work. Looking now.

tru · 2024-09-24T06:35:21Z

Seems like there are still a lot of CI problems here?

ldionne · 2024-10-01T16:09:00Z

libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp

-//
+
 // UNSUPPORTED: c++03, c++11, c++14
+// XFAIL: LIBCXX-PICOLIBC-FIXME


@domin144 @mplatings I don't quite understand why this fails. There seems to be missing the __atomic_is_lock_free intrinsic on the Picolibc setup, but the other atomic tests are working. Could you take a look?

@DavidSpickett

I will merge this because we want to cherry-pick onto LLVM 19 and it's better to have this test for most platforms than for none of them, but I would really appreciate if we could address this in a follow-up.

ldionne · 2024-10-02T12:54:54Z

/cherry-pick b456619

…un (llvm#106077) (cherry picked from commit b456619)

llvmbot · 2024-10-02T13:00:14Z

/pull-request #110838

…un (llvm#106077)

Currently this test is completely xfailed as part of the patch #106077. But this test works on A and R profile, not in v7M profile. Because the test contain cases in which m-profile will fail for atomic types greater than 4 bytes in size.

…un (llvm#106077) (cherry picked from commit b456619)

cpplearner · 2024-10-19T03:22:03Z

libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp

  if (is_always_lock_free) {
-    std::same_as<bool> decltype(auto) is_lock_free = a.is_lock_free();
+    auto is_lock_free = a.is_lock_free();
+    ASSERT_SAME_TYPE(decltype(is_always_lock_free), bool const);


Suggested change

ASSERT_SAME_TYPE(decltype(is_always_lock_free), bool const);

ASSERT_SAME_TYPE(decltype(is_lock_free), bool);

Would you open a PR to fix this?

@ldionne

… `-Wno-psabi` (#113608) MSVC doesn't understand `-Wno-psabi`, which was introduced here by @ldionne in #106077. Using `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` (implemented by #75317) avoids passing this to MSVC.

@ldionne

… `-Wno-psabi` (llvm#113608) MSVC doesn't understand `-Wno-psabi`, which was introduced here by @ldionne in llvm#106077. Using `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` (implemented by llvm#75317) avoids passing this to MSVC.

ldionne requested a review from a team as a code owner August 26, 2024 14:11

ldionne mentioned this pull request Aug 26, 2024

[libc++] Fix bug in atomic_ref's calculation of lock_free-ness #99570

Merged

ldionne added this to the LLVM 19.X Release milestone Aug 26, 2024

llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 26, 2024

dalg24 approved these changes Aug 26, 2024

View reviewed changes

ldionne mentioned this pull request Aug 26, 2024

[libc++][test] Add missing <concepts> to is_always_lock_free test #105966

Merged

ldionne force-pushed the review/is-always-lock-free-test-name branch from 03a3f8e to 6ff7ed8 Compare August 26, 2024 15:55

philnik777 approved these changes Sep 11, 2024

View reviewed changes

ldionne force-pushed the review/is-always-lock-free-test-name branch from 6ff7ed8 to eddceb7 Compare September 17, 2024 14:31

ldionne mentioned this pull request Sep 26, 2024

[release/19.x][libc++] Disable the clang-tidy checks to get CI back (#109989) #110162

Merged

ldionne force-pushed the review/is-always-lock-free-test-name branch 3 times, most recently from 17e0d67 to 8225a05 Compare September 30, 2024 18:29

tru force-pushed the review/is-always-lock-free-test-name branch from 8225a05 to 037efef Compare October 1, 2024 07:04

[libc++] Fix name of is_always_lock_free test which was never being run

74dd036

ldionne force-pushed the review/is-always-lock-free-test-name branch from 037efef to 74dd036 Compare October 1, 2024 13:33

FIXME for Picolibc

f68ba48

ldionne commented Oct 1, 2024

View reviewed changes

ldionne merged commit b456619 into llvm:main Oct 2, 2024

ldionne deleted the review/is-always-lock-free-test-name branch October 2, 2024 12:54

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Oct 2, 2024

[libc++] Fix name of is_always_lock_free test which was never being r…

4043627

…un (llvm#106077) (cherry picked from commit b456619)

Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this pull request Oct 3, 2024

[libc++] Fix name of is_always_lock_free test which was never being r…

4a6cbb3

…un (llvm#106077)

simpal01 mentioned this pull request Oct 8, 2024

Add 64bit atomic check in the is_always_lock_free_pass test. #111540

Merged

tru pushed a commit to llvmbot/llvm-project that referenced this pull request Oct 11, 2024

[libc++] Fix name of is_always_lock_free test which was never being r…

b0b36c0

…un (llvm#106077) (cherry picked from commit b456619)

cpplearner reviewed Oct 19, 2024

View reviewed changes

StephanTLavavej mentioned this pull request Oct 24, 2024

[libc++][test] Use ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings) for -Wno-psabi #113608

Merged

thewtex mentioned this pull request Feb 10, 2025

llvmorg 19.1.5 libcxxabi pthread lib name #126605

Closed

	ASSERT_SAME_TYPE(decltype(is_always_lock_free), bool const);
	ASSERT_SAME_TYPE(decltype(is_lock_free), bool);

Conversation

ldionne commented Aug 26, 2024

Uh oh!

llvmbot commented Aug 26, 2024

Uh oh!

tru commented Sep 1, 2024

Uh oh!

tru commented Sep 10, 2024

Uh oh!

tru commented Sep 11, 2024

Uh oh!

philnik777 commented Sep 11, 2024

Uh oh!

ldionne commented Sep 17, 2024

Uh oh!

tru commented Sep 24, 2024

Uh oh!

ldionne Oct 1, 2024

Choose a reason for hiding this comment

Uh oh!

mplatings Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

ldionne Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

ldionne commented Oct 2, 2024

Uh oh!

llvmbot commented Oct 2, 2024

Uh oh!

cpplearner Oct 19, 2024

Choose a reason for hiding this comment

Uh oh!

dalg24 Oct 19, 2024

Choose a reason for hiding this comment

Uh oh!

ldionne Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants