release/19.x: [libc++] Fix name of is_always_lock_free test which was never being run (#106077)#110838
Merged
tru merged 1 commit intollvm:release/19.xfrom Oct 11, 2024
Merged
Conversation
Member
Author
|
@ldionne What do you think about merging this PR to the release branch? |
Member
Author
|
@llvm/pr-subscribers-libcxx Author: None (llvmbot) ChangesBackport b456619 Requested by: @ldionne Full diff: https://github.com/llvm/llvm-project/pull/110838.diff 1 Files Affected:
diff --git a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.cpp b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
similarity index 94%
rename from libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.cpp
rename to libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
index 2dc7f5c7654193..723e7b36f50319 100644
--- a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.cpp
+++ b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
@@ -5,8 +5,9 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
-//
+
// UNSUPPORTED: c++03, c++11, c++14
+// XFAIL: LIBCXX-PICOLIBC-FIXME
// <atomic>
//
@@ -15,6 +16,10 @@
//
// static constexpr bool is_always_lock_free;
+// Ignore diagnostic about vector types changing the ABI on some targets, since
+// that is irrelevant for this test.
+// ADDITIONAL_COMPILE_FLAGS: -Wno-psabi
+
#include <atomic>
#include <cassert>
#include <cstddef>
@@ -26,7 +31,8 @@ template <typename T>
void check_always_lock_free(std::atomic<T> const& a) {
using InfoT = LockFreeStatusInfo<T>;
- constexpr std::same_as<const bool> decltype(auto) is_always_lock_free = std::atomic<T>::is_always_lock_free;
+ constexpr auto is_always_lock_free = std::atomic<T>::is_always_lock_free;
+ ASSERT_SAME_TYPE(decltype(is_always_lock_free), bool const);
// If we know the status of T for sure, validate the exact result of the function.
if constexpr (InfoT::status_known) {
@@ -44,7 +50,8 @@ void check_always_lock_free(std::atomic<T> const& a) {
// In all cases, also sanity-check it based on the implication always-lock-free => lock-free.
if (is_always_lock_free) {
- std::same_as<bool> decltype(auto) is_lock_free = a.is_lock_free();
+ auto is_lock_free = a.is_lock_free();
+ ASSERT_SAME_TYPE(decltype(is_always_lock_free), bool const);
assert(is_lock_free);
}
ASSERT_NOEXCEPT(a.is_lock_free());
|
ldionne
approved these changes
Oct 2, 2024
Member
|
Impact: basically none, this adds test coverage we should always have had. |
…un (llvm#106077) (cherry picked from commit b456619)
|
@ldionne (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport b456619
Requested by: @ldionne