Skip to content

fix(routing): Fix header name when raising MethodNotAllowedException#4539

Merged
provinzkraut merged 1 commit intolitestar-org:mainfrom
edgarrmondragon:allow-header
Jan 4, 2026
Merged

fix(routing): Fix header name when raising MethodNotAllowedException#4539
provinzkraut merged 1 commit intolitestar-org:mainfrom
edgarrmondragon:allow-header

Conversation

@edgarrmondragon
Copy link
Copy Markdown
Contributor

@edgarrmondragon edgarrmondragon commented Jan 4, 2026

Description

#4289 used the wrong header name.

Closes

Closes #4277 (for good).

@edgarrmondragon
fix(routing): Fix header name when raising MethodNotAllowedException
e535faf 
- litestar-org#4277
- litestar-org#4289

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
@edgarrmondragon edgarrmondragon requested review from a team as code owners January 4, 2026 17:49
@github-actions github-actions bot added area/private-api This PR involves changes to the privatized API size: small type/bug pr/external Triage Required 🏥 This requires triage labels Jan 4, 2026
@edgarrmondragon edgarrmondragon mentioned this pull request Jan 4, 2026
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 4, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (d95a347) to head (e535faf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4539   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         296      296           
  Lines       15303    15303           
  Branches     1715     1715           
=======================================
  Hits        14972    14972           
  Misses        189      189           
  Partials      142      142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sobolevn
sobolevn approved these changes Jan 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups :)

LGTM

@provinzkraut provinzkraut merged commit abbbf4a into litestar-org:main Jan 4, 2026
28 checks passed
@edgarrmondragon edgarrmondragon deleted the allow-header branch January 5, 2026 12:18
provinzkraut pushed a commit that referenced this pull request Jan 25, 2026
@edgarrmondragon @provinzkraut
fix(routing): Fix header name when raising MethodNotAllowedException (
a3a002e 
#4539)

- #4277
- #4289

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>

(cherry picked from commit abbbf4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

area/private-api This PR involves changes to the privatized API pr/external size: small Triage Required 🏥 This requires triage type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: 405 Method Not Allowed response should include the Allow header

3 participants

@edgarrmondragon @sobolevn @provinzkraut