Skip to content

fix(routing): Ensure a MethodNotAllowedException exception during routing properly sets Allow header #4289

Merged
provinzkraut merged 1 commit intomainfrom
fix-not-allowed
Sep 13, 2025
Merged

fix(routing): Ensure a MethodNotAllowedException exception during routing properly sets Allow header #4289
provinzkraut merged 1 commit intomainfrom
fix-not-allowed

Conversation

@provinzkraut
Copy link
Copy Markdown
Member

@provinzkraut provinzkraut commented Sep 13, 2025

MethodNotAllowedException exceptions raised during routing did not include the Allow header, which must be present in a 405 Method Not Allowed response.

Fixes #4277.

@provinzkraut provinzkraut requested review from a team as code owners September 13, 2025 17:52
@github-actions github-actions bot added area/private-api This PR involves changes to the privatized API size: small type/bug pr/internal labels Sep 13, 2025
@provinzkraut provinzkraut enabled auto-merge (squash) September 13, 2025 17:52
@provinzkraut provinzkraut merged commit 262c776 into main Sep 13, 2025
26 checks passed
@provinzkraut provinzkraut deleted the fix-not-allowed branch September 13, 2025 17:55
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.25%. Comparing base (7979d6d) to head (4923172).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4289   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         343      343           
  Lines       15822    15823    +1     
  Branches     1745     1745           
=======================================
+ Hits        15546    15547    +1     
  Misses        138      138           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

provinzkraut added a commit that referenced this pull request Sep 21, 2025
…outing properly sets `Allow` header (#4289)

Add "Allow" header to 405 response

(cherry picked from commit 262c776)
@edgarrmondragon
Copy link
Copy Markdown
Contributor

Hey team 👋

Is there a timeline for the release of this fix? Neither this PR nor the linked issue are part of any GitHub milestone.

@provinzkraut
Copy link
Copy Markdown
Member Author

This was released in 2.18.0. The info is available on the issue: #4277 (comment)

edgarrmondragon added a commit to edgarrmondragon/litestar that referenced this pull request Jan 4, 2026
- litestar-org#4277
- litestar-org#4289

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
@edgarrmondragon
Copy link
Copy Markdown
Contributor

This was released in 2.18.0. The info is available on the issue: #4277 (comment)

I see what's going on:

provinzkraut pushed a commit that referenced this pull request Jan 4, 2026
#4539)

- #4277
- #4289

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
provinzkraut pushed a commit that referenced this pull request Jan 25, 2026
#4539)

- #4277
- #4289

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>

(cherry picked from commit abbbf4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/private-api This PR involves changes to the privatized API pr/internal size: small type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: 405 Method Not Allowed response should include the Allow header

3 participants