Update wireit by aomarks · Pull Request #4722 · lit/lit

aomarks · 2024-08-05T19:27:07Z

Part 1 of bringing in the security improvement from google/wireit#1146. I will update the GitHub Action version in a follow-up PR, because doing both at once breaks the tachometer workflow (because tachometer is trying to build main but with this PR's GitHub Action version, which is incompatible until the wireit version is bumped).

changeset-bot · 2024-08-05T19:27:11Z

⚠️ No Changeset found

Latest commit: bbffa67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-08-05T19:27:23Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-0.60ms - +0.33ms)
^{this-change vs tip-of-tree}

render

this-change: 46.18ms - 47.61ms
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +4% (-0.51ms - +0.70ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.29ms - +0.71ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.22ms - +0.89ms)
^{this-change vs tip-of-tree}

update

this-change: 491.76ms - 499.19ms
this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +4% (-3.24ms - +1.66ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.57ms - +2.12ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +1% (-1.67ms - +5.25ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 495.20ms - 499.95ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.07ms - +3.88ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 127.0.6533.88
Sample size: 50
Built by: Benchmarks #6335
Commit: bbffa67

render

Version	Avg time	vs
	46.18ms - 47.61ms	-

update

Version	Avg time	vs
	491.76ms - 499.19ms	-

update-reflect

Version	Avg time	vs
	495.20ms - 499.95ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 127.0.6533.88
Sample size: 30
Built by: Benchmarks #6335
Commit: bbffa67

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.45ms - 19.37ms	-	unsure 🔍 -3% - +4% -0.51ms - +0.70ms	unsure 🔍 -3% - +3% -0.65ms - +0.57ms
tip-of-tree tip-of-tree	18.43ms - 19.21ms	unsure 🔍 -4% - +3% -0.70ms - +0.51ms	-	unsure 🔍 -4% - +2% -0.69ms - +0.42ms
previous-release previous-release	18.55ms - 19.35ms	unsure 🔍 -3% - +3% -0.57ms - +0.65ms	unsure 🔍 -2% - +4% -0.42ms - +0.69ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	36.34ms - 39.95ms	-	unsure 🔍 -8% - +4% -3.24ms - +1.66ms	unsure 🔍 -10% - +2% -3.95ms - +1.02ms
tip-of-tree tip-of-tree	37.28ms - 40.58ms	unsure 🔍 -4% - +9% -1.66ms - +3.24ms	-	unsure 🔍 -8% - +4% -3.05ms - +1.69ms
previous-release previous-release	37.90ms - 41.31ms	unsure 🔍 -3% - +10% -1.02ms - +3.95ms	unsure 🔍 -4% - +8% -1.69ms - +3.05ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.75ms - 12.46ms	-	unsure 🔍 -5% - +3% -0.60ms - +0.33ms	unsure 🔍 -5% - +3% -0.66ms - +0.34ms
tip-of-tree tip-of-tree	11.94ms - 12.53ms	unsure 🔍 -3% - +5% -0.33ms - +0.60ms	-	unsure 🔍 -4% - +4% -0.49ms - +0.44ms
previous-release previous-release	11.91ms - 12.62ms	unsure 🔍 -3% - +5% -0.34ms - +0.66ms	unsure 🔍 -4% - +4% -0.44ms - +0.49ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 127.0.6533.88
Sample size: 50
Built by: Benchmarks #6335
Commit: bbffa67

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.66ms - 34.41ms	-	unsure 🔍 -1% - +2% -0.29ms - +0.71ms	unsure 🔍 -1% - +2% -0.48ms - +0.59ms
tip-of-tree tip-of-tree	33.49ms - 34.15ms	unsure 🔍 -2% - +1% -0.71ms - +0.29ms	-	unsure 🔍 -2% - +1% -0.66ms - +0.35ms
previous-release previous-release	33.60ms - 34.36ms	unsure 🔍 -2% - +1% -0.59ms - +0.48ms	unsure 🔍 -1% - +2% -0.35ms - +0.66ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	71.11ms - 73.15ms	-	unsure 🔍 -1% - +3% -0.57ms - +2.12ms	unsure 🔍 -3% - +3% -1.96ms - +2.04ms
tip-of-tree tip-of-tree	70.48ms - 72.23ms	unsure 🔍 -3% - +1% -2.12ms - +0.57ms	-	unsure 🔍 -4% - +2% -2.66ms - +1.19ms
previous-release previous-release	70.37ms - 73.81ms	unsure 🔍 -3% - +3% -2.04ms - +1.96ms	unsure 🔍 -2% - +4% -1.19ms - +2.66ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 127.0.6533.88
Sample size: 50
Built by: Benchmarks #6335
Commit: bbffa67

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.27ms - 32.13ms	-	unsure 🔍 -1% - +3% -0.22ms - +0.89ms	unsure 🔍 -1% - +3% -0.41ms - +0.80ms
tip-of-tree tip-of-tree	31.01ms - 31.71ms	unsure 🔍 -3% - +1% -0.89ms - +0.22ms	-	unsure 🔍 -2% - +1% -0.70ms - +0.41ms
previous-release previous-release	31.08ms - 31.93ms	unsure 🔍 -3% - +1% -0.80ms - +0.41ms	unsure 🔍 -1% - +2% -0.41ms - +0.70ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	512.03ms - 517.64ms	-	unsure 🔍 -0% - +1% -1.67ms - +5.25ms	unsure 🔍 -1% - +1% -2.76ms - +4.62ms
tip-of-tree tip-of-tree	511.02ms - 515.07ms	unsure 🔍 -1% - +0% -5.25ms - +1.67ms	-	unsure 🔍 -1% - +0% -4.00ms - +2.28ms
previous-release previous-release	511.50ms - 516.31ms	unsure 🔍 -1% - +1% -4.62ms - +2.76ms	unsure 🔍 -0% - +1% -2.28ms - +4.00ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	550.73ms - 556.66ms	-	unsure 🔍 -1% - +1% -4.07ms - +3.88ms	unsure 🔍 -1% - +1% -5.68ms - +3.32ms
tip-of-tree tip-of-tree	551.15ms - 556.43ms	unsure 🔍 -1% - +1% -3.88ms - +4.07ms	-	unsure 🔍 -1% - +1% -5.38ms - +3.21ms
previous-release previous-release	551.49ms - 558.25ms	unsure 🔍 -1% - +1% -3.32ms - +5.68ms	unsure 🔍 -1% - +1% -3.21ms - +5.38ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-08-05T19:29:23Z

The size of lit-html.js and lit-core.min.js are as expected.

Follow up to #4722 (bringing in google/wireit#1146).

aomarks requested review from augustjk and rictic August 5, 2024 19:27

aomarks requested a review from kevinpschaaf as a code owner August 5, 2024 19:27

aomarks marked this pull request as draft August 5, 2024 19:41

justinfagnani self-requested a review August 5, 2024 21:16

Update wireit and setup-github-caching action

bbcf875

aomarks force-pushed the update-wireit branch from 0ca8d4f to bbcf875 Compare August 13, 2024 02:57

Only update the wireit version initially

bbffa67

aomarks changed the title ~~Update wireit and setup-github-caching action~~ Update wireit Aug 13, 2024

aomarks marked this pull request as ready for review August 13, 2024 03:13

aomarks enabled auto-merge (squash) August 13, 2024 03:14

rictic approved these changes Aug 13, 2024

View reviewed changes

aomarks merged commit 7d7a8c4 into main Aug 13, 2024

aomarks deleted the update-wireit branch August 13, 2024 03:24

aomarks mentioned this pull request Aug 13, 2024

Update GitHub caching action version #4728

Merged

aomarks added a commit that referenced this pull request Aug 13, 2024

Update GitHub caching action version (#4728)

440a440

Follow up to #4722 (bringing in google/wireit#1146).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update wireit#4722

Update wireit#4722
aomarks merged 2 commits intomainfrom
update-wireit

aomarks commented Aug 5, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 5, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Aug 5, 2024 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

github-actions bot commented Aug 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aomarks commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

github-actions bot commented Aug 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aomarks commented Aug 5, 2024 •

edited

Loading

changeset-bot bot commented Aug 5, 2024 •

edited

Loading

github-actions bot commented Aug 5, 2024 •

edited

Loading