Skip to content

Update GitHub caching action version#4728

Merged
aomarks merged 1 commit intomainfrom
update-wireit-action
Aug 13, 2024
Merged

Update GitHub caching action version#4728
aomarks merged 1 commit intomainfrom
update-wireit-action

Conversation

@aomarks
Copy link
Member

@aomarks aomarks commented Aug 13, 2024

Follow up to #4722 (bringing in google/wireit#1146).

@aomarks aomarks requested a review from kevinpschaaf as a code owner August 13, 2024 04:15
@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: acbbfa3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aomarks aomarks requested review from augustjk and rictic August 13, 2024 04:15
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +4% (-0.66ms - +0.45ms)
    this-change vs tip-of-tree

render

  • this-change: 45.10ms - 46.93ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-0.36ms - +0.74ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-0.07ms - +0.82ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-0.52ms - +0.87ms)
    this-change vs tip-of-tree

update

  • this-change: 465.98ms - 480.38ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +6% (-2.30ms - +2.22ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-1.28ms - +0.80ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-10.05ms - +4.51ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 465.70ms - 478.52ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-10.30ms - +3.90ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
45.10ms - 46.93ms-

update

VersionAvg timevs
465.98ms - 480.38ms-

update-reflect

VersionAvg timevs
465.70ms - 478.52ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.58ms - 19.38ms-unsure 🔍
-2% - +4%
-0.36ms - +0.74ms		unsure 🔍
-0% - +5%
-0.05ms - +0.97ms
tip-of-tree
tip-of-tree		18.41ms - 19.17msunsure 🔍
-4% - +2%
-0.74ms - +0.36ms		-unsure 🔍
-1% - +4%
-0.22ms - +0.76ms
previous-release
previous-release		18.21ms - 18.84msunsure 🔍
-5% - +0%
-0.97ms - +0.05ms		unsure 🔍
-4% - +1%
-0.76ms - +0.22ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.32ms - 39.48ms-unsure 🔍
-6% - +6%
-2.30ms - +2.22ms		unsure 🔍
-5% - +7%
-1.72ms - +2.51ms
tip-of-tree
tip-of-tree		36.32ms - 39.56msunsure 🔍
-6% - +6%
-2.22ms - +2.30ms		-unsure 🔍
-5% - +7%
-1.71ms - +2.58ms
previous-release
previous-release		36.10ms - 38.92msunsure 🔍
-7% - +5%
-2.51ms - +1.72ms		unsure 🔍
-7% - +4%
-2.58ms - +1.71ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.48ms - 12.32ms-unsure 🔍
-5% - +4%
-0.66ms - +0.45ms		unsure 🔍
-4% - +5%
-0.52ms - +0.57ms
tip-of-tree
tip-of-tree		11.64ms - 12.36msunsure 🔍
-4% - +6%
-0.45ms - +0.66ms		-unsure 🔍
-3% - +5%
-0.37ms - +0.63ms
previous-release
previous-release		11.52ms - 12.22msunsure 🔍
-5% - +4%
-0.57ms - +0.52ms		unsure 🔍
-5% - +3%
-0.63ms - +0.37ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
33.43ms - 34.05ms-unsure 🔍
-0% - +2%
-0.07ms - +0.82ms		unsure 🔍
-1% - +1%
-0.37ms - +0.48ms
tip-of-tree
tip-of-tree		33.05ms - 33.69msunsure 🔍
-2% - +0%
-0.82ms - +0.07ms		-unsure 🔍
-2% - +0%
-0.75ms - +0.11ms
previous-release
previous-release		33.40ms - 33.97msunsure 🔍
-1% - +1%
-0.48ms - +0.37ms		unsure 🔍
-0% - +2%
-0.11ms - +0.75ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
66.53ms - 67.81ms-unsure 🔍
-2% - +1%
-1.28ms - +0.80ms		unsure 🔍
-2% - +0%
-1.60ms - +0.03ms
tip-of-tree
tip-of-tree		66.59ms - 68.23msunsure 🔍
-1% - +2%
-0.80ms - +1.28ms		-unsure 🔍
-2% - +1%
-1.51ms - +0.41ms
previous-release
previous-release		67.46ms - 68.45msunsure 🔍
-0% - +2%
-0.03ms - +1.60ms		unsure 🔍
-1% - +2%
-0.41ms - +1.51ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
30.88ms - 31.93ms-unsure 🔍
-2% - +3%
-0.52ms - +0.87ms		unsure 🔍
-1% - +3%
-0.35ms - +0.96ms
tip-of-tree
tip-of-tree		30.77ms - 31.69msunsure 🔍
-3% - +2%
-0.87ms - +0.52ms		-unsure 🔍
-2% - +2%
-0.48ms - +0.74ms
previous-release
previous-release		30.71ms - 31.50msunsure 🔍
-3% - +1%
-0.96ms - +0.35ms		unsure 🔍
-2% - +2%
-0.74ms - +0.48ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
481.33ms - 491.28ms-unsure 🔍
-2% - +1%
-10.05ms - +4.51ms		unsure 🔍
-1% - +2%
-5.62ms - +7.59ms
tip-of-tree
tip-of-tree		483.76ms - 494.38msunsure 🔍
-1% - +2%
-4.51ms - +10.05ms		-unsure 🔍
-1% - +2%
-3.10ms - +10.62ms
previous-release
previous-release		480.97ms - 489.66msunsure 🔍
-2% - +1%
-7.59ms - +5.62ms		unsure 🔍
-2% - +1%
-10.62ms - +3.10ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
514.83ms - 524.39ms-unsure 🔍
-2% - +1%
-10.30ms - +3.90ms		unsure 🔍
-1% - +1%
-7.24ms - +5.79ms
tip-of-tree
tip-of-tree		517.57ms - 528.06msunsure 🔍
-1% - +2%
-3.90ms - +10.30ms		-unsure 🔍
-1% - +2%
-4.39ms - +9.34ms
previous-release
previous-release		515.91ms - 524.76msunsure 🔍
-1% - +1%
-5.79ms - +7.24ms		unsure 🔍
-2% - +1%
-9.34ms - +4.39ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024

The size of lit-html.js and lit-core.min.js are as expected.

@aomarks aomarks merged commit 440a440 into main Aug 13, 2024
@aomarks aomarks deleted the update-wireit-action branch August 13, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@rictic rictic Awaiting requested review from rictic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aomarks @augustjk