Add testing for alternative python versions#401
Conversation
Since this project claims to work on py37+, I added explicit tests for py37, py39, and the newly released py310. I found in https://github.com/mapping-commons/sssom-py/pull/167/checks?check_run_id=3837024754 that it breaks in py310, so this is expected to fail and lead to other bug fixes for the time being
|
looks like 3.10 passes! so will this increase the time of github actions 4x? |
|
OK, so it looks like your PR is on main.yaml, not pr-test.yaml. pr-test.yaml already tests 3.7.1, 3.8, and 3.9. I think main.yaml should be completely consistent with pr-test. We are also opening a new issue to support 3.10 |
|
Support for 3.10 is in #404 - I think we can close this? |
|
The tests run in parallel so adding more python versions won't slow down the overall build time (except the fact that older python versions are themselves slower) |
|
#764 added tests for other Python versions (3.7...3.10). |
|
Thanks @dalito! May be easiest to do this on a fresh PR as the workflows have changed so much? |
|
I think we already have this (probably as a result of this ticket, thanks all! :) ) in the github action "main.yaml". which runs on every PR. I do like the convention of pr-test.yaml being the file that runs on each PR instead of 'main' -- but I think we could address that in another PR (I would go in and fix this PR's conflicts for everyone, but because it is a fork, I think its best to just open another PR). |
Fix formatting in CONTRIBUTING.md
Closes #404
Since this project claims to work on py37+, I added explicit tests for py37, py39, and the newly released py310. These tests are applied in both the main.yml and pr-test.yml configurations.
I found in https://github.com/mapping-commons/sssom-py/pull/167/checks?check_run_id=3837024754 that it breaks in py310, so this is expected to fail and lead to other bug fixes for the time being