Skip to content

update Github Actions to work with poetry#764

Merged
sujaypatil96 merged 2 commits intomainfrom
spatil/github-actions-poetry
May 10, 2022
Merged

update Github Actions to work with poetry#764
sujaypatil96 merged 2 commits intomainfrom
spatil/github-actions-poetry

Conversation

@sujaypatil96
Copy link
Member

The same Github Actions from the exemplar linkml-runtime framework have been ported over to work with linkml core, replacing the Actions that previously used pipenv.

@sujaypatil96 sujaypatil96 requested a review from cmungall May 10, 2022 07:28
@sujaypatil96 sujaypatil96 added the devops poetry (now uv), setuptools, actions, etc. label May 10, 2022
@sujaypatil96 sujaypatil96 linked an issue May 10, 2022 that may be closed by this pull request
3 tasks
@sujaypatil96 sujaypatil96 force-pushed the spatil/github-actions-poetry branch from da76a1c to 71b9fd4 Compare May 10, 2022 08:38
@sujaypatil96
Copy link
Member Author

@dalito: any thoughts as to why the Windows tests are not going through here?

@dalito
Copy link
Member

dalito commented May 10, 2022

Great to add Windows to the CI tests. I am not too surprised about the failures: linkML had still some minor issues in contrast to linkML-runtime. I will have a look.

@sujaypatil96
Copy link
Member Author

Oh perfect, thank you, I appreciate it.

@cmungall
Copy link
Member

Let’s break this down and handle things incrementally

first task is to complete the transition to poetry. We are in an odd in between state. Let’s fix asap. If there were hidden windows issues with the tests that were masked because we didn’t do windows tests then leave windows tests out of this pr. Let’s get the transition completed and then immediately make a new pr that adds the windows tests and solve those

@sujaypatil96 sujaypatil96 force-pushed the spatil/github-actions-poetry branch 2 times, most recently from 81c701a to 71b9fd4 Compare May 10, 2022 17:33
@dalito
Copy link
Member

dalito commented May 10, 2022

Ok. I will wait untill this is merged and look at the windows failures afterwards.

@sujaypatil96 sujaypatil96 merged commit e725cc9 into main May 10, 2022
@sujaypatil96
Copy link
Member Author

sujaypatil96 commented May 10, 2022

Done @dalito. Feel free to take a look at and add Windows tests if and when you have some time, no rush. Thank you.😁😁

@sujaypatil96 sujaypatil96 deleted the spatil/github-actions-poetry branch May 10, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops poetry (now uv), setuptools, actions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github Actions still runs pipenv instead of poetry to run checks

3 participants