Ensure chardet is installed when testing using tox#548
Merged
cjmayo merged 1 commit intolinkchecker:masterfrom Aug 13, 2021
Merged
Ensure chardet is installed when testing using tox#548cjmayo merged 1 commit intolinkchecker:masterfrom
cjmayo merged 1 commit intolinkchecker:masterfrom
Conversation
Beautiful Soup uses chardet, if installed, to detect character encodings. This can lead to different test results based on whether chardet is installed or not. Requests < 2.26.0 requires chardet, but since 2.26.0 Requests requires charset_normalizer. Explicitly installing chardet maintains consistent test results.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2021
Ensure chardet is installed when testing using tox b4d68ba
github-actions bot
pushed a commit
to cjmayo/linkchecker
that referenced
this pull request
Aug 13, 2021
Ensure chardet is installed when testing using tox b4d68ba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beautiful Soup uses chardet, if installed, to detect character
encodings. This can lead to different test results based on whether
chardet is installed or not.
Requests < 2.26.0 requires chardet, but since 2.26.0 Requests requires
charset_normalizer.
Explicitly installing chardet maintains consistent test results.
====
Testing for the first time here. Let's see if it closes #547.