packages/diagram/src/context/TagStylesContext.tsx (1)

12-37: ⚡ Quick win

Consider adding JSDoc to the now-exported function.

Now that generateColorVars is exported, it forms part of the public API. Per coding guidelines, public methods should have JSDoc documentation describing parameters, return values, and behavior.

📝 Suggested JSDoc

+/**
+ * Generates CSS custom property declarations for tag styling.
+ * 
+ * For custom hex colors, derives a high-contrast text color using APCA.
+ * For known Radix color names, emits Radix-based CSS variable references.
+ * 
+ * `@param` spec - Tag specification containing the color property
+ * `@returns` CSS string with custom property declarations, or empty string for unrecognized colors
+ */
 export const generateColorVars = (spec: TagSpecification): string => {

As per coding guidelines: Use JSDoc to document public classes and methods.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/diagram/src/context/TagStylesContext.tsx` around lines 12 - 37, Add
a JSDoc block above the exported function generateColorVars that documents the
function purpose, the parameter spec (type TagSpecification and what fields are
used, e.g. spec.color), possible control flow (when isTagColorSpecified(spec) is
true vs when color is in radixColors), return type (string containing CSS custom
property declarations or empty string) and any important details (which CSS
variables are produced, the use of APCA contrasted color via
getContrastedColorsAPCA, and the special-case mapping to 'textcolor' for
mint/grass/lime/yellow/amber). Keep the description concise and include `@param`
and `@returns` tags referencing TagSpecification and string respectively so this
exported API is properly documented.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

packages/diagram/src/context/TagStylesContext.spec.ts (1)

59-68: 💤 Low value

Consider eliminating the redundant call in the malformed input test.

Each malformed input is passed to generateColorVars twice (lines 63 and 65). You can call once and assert both that it doesn't throw and that the result is empty.

♻️ More efficient pattern

-    for (const malformed of ['`#zzzzzz`', '`#12`', 'rgb(garbage)']) {
-      expect(() => generateColorVars({ color: malformed as TagSpecification['color'] }))
-        .not.toThrow()
-      const css = generateColorVars({ color: malformed as TagSpecification['color'] })
-      expect(css).toBe('')
-    }
+    for (const malformed of ['`#zzzzzz`', '`#12`', 'rgb(garbage)']) {
+      let css: string
+      expect(() => {
+        css = generateColorVars({ color: malformed as TagSpecification['color'] })
+      }).not.toThrow()
+      expect(css!).toBe('')
+    }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/diagram/src/context/TagStylesContext.spec.ts` around lines 59 - 68,
The test in TagStylesContext.spec.ts redundantly calls generateColorVars twice
for each malformed color; change the loop to call generateColorVars once per
malformed value, storing the result in a local variable, then assert that the
call did not throw and that the returned css string is empty. Update the test
that iterates over malformed inputs (referencing generateColorVars and
TagSpecification['color']) to use a single invocation per iteration and assert
both expectations on the stored result.

packages/diagram/src/context/TagStylesContext.tsx (1)

12-12: 💤 Low value

Consider adding JSDoc for the exported function.

Since generateColorVars is now exported, adding JSDoc would help consumers understand its purpose and contract (input format, return value structure, validation behavior).

📝 Suggested JSDoc

+/**
+ * Generates CSS custom property declarations for a tag specification.
+ * For custom colors (hex/rgb), derives APCA-based high-contrast text color.
+ * For named Radix colors, emits standard Radix scale variables.
+ * Returns empty string for invalid or unknown colors.
+ */
 export const generateColorVars = (spec: TagSpecification): string => {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/diagram/src/context/TagStylesContext.tsx` at line 12, Add JSDoc for
the exported function generateColorVars describing its purpose, the
TagSpecification parameter shape (required fields, types and any optional
properties or validation behavior), and the return value (string format and what
CSS variables it contains); include examples of accepted input and note any edge
cases (e.g., missing colors or defaults applied) and mention that the function
may throw or sanitize invalid values so consumers know expected behavior.