packages/core/src/utils/colors.ts (1)

13-23: Avoid the tuple cast in the new utility.

rgb.map(...) widens the tuple to number[], requiring the as cast. A small helper function preserves the return type without casting, aligning with the guideline: "Use TypeScript with explicit types; avoid using any and type casts with as".

♻️ Proposed refactor

 export function adjustToneRgb(rgb: [number, number, number], factor: number): [number, number, number] {
   // Clamp factor to range [-1, 1]
   factor = Math.max(-1, Math.min(1, factor))
 
-  return rgb.map(channel => {
+  const adjustChannel = (channel: number): number => {
     const adjusted = factor > 0
       ? channel + (255 - channel) * factor // lighten
       : channel * (1 + factor) // darken
     // return a value between 0 and 255
     return Math.round(Math.max(0, Math.min(255, adjusted)))
-  }) as [number, number, number]
+  }
+
+  return [adjustChannel(rgb[0]), adjustChannel(rgb[1]), adjustChannel(rgb[2])]
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/src/utils/colors.ts` around lines 13 - 23, The adjustToneRgb
function currently uses rgb.map(...) which widens the [number,number,number]
tuple to number[] and forces an unsafe "as" cast; change the implementation to
preserve the tuple type without casting by avoiding Array.prototype.map — either
destructure the input and compute each channel explicitly (return [calc(r),
calc(g), calc(b)]), or introduce a small typed helper (e.g., map3) that accepts
[A,B,C] and a mapper to return [R,R,R]; update adjustToneRgb to use that helper
or the explicit per-channel calculations and remove the "as [number, number,
number]" cast.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

packages/core/src/styles/compute-color-values.ts (2)

53-53: Redundant chroma(...).hex() round-trip.

adjustToneHex already returns a hex string, so wrapping it in chroma(...).hex() is a no-op conversion. You can drop the wrapper and cast the result directly.

♻️ Proposed simplification

-  const rel_secondary = chroma(adjustToneHex(el_main, -0.25)).hex() as HexColor
+  const rel_secondary = adjustToneHex(el_main, -0.25) as HexColor

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/src/styles/compute-color-values.ts` at line 53, The expression
wrapping adjustToneHex(...) with chroma(...).hex() is redundant; update the
assignment to set rel_secondary directly to the hex string returned by
adjustToneHex and cast it to HexColor (i.e., replace
chroma(adjustToneHex(el_main, -0.25)).hex() with adjustToneHex(el_main, -0.25)
and keep the existing cast), referencing the rel_secondary constant and the
adjustToneHex helper.

---

104-111: Redundant chroma(x.hex()).hex() for loContrast.

lightColorRgb.hex() / darkColorRgb.hex() already yields a hex string; re-wrapping through chroma(...).hex() only adds work without changing the value. The hiContrast cases do need the wrap because .brighten(0.4) / .darken(0.4) return a chroma.Color, but loContrast can be simplified.

♻️ Proposed simplification

   if (Math.abs(contrastWithLight) > Math.abs(contrastWithDark)) {
     return {
       hiContrast: chroma(lightColorRgb.brighten(0.4)).hex() as HexColor,
-      loContrast: chroma(lightColorRgb.hex()).hex() as HexColor,
+      loContrast: lightColorRgb.hex() as HexColor,
     }
   } else {
     return {
       hiContrast: chroma(darkColorRgb.darken(0.4)).hex() as HexColor,
-      loContrast: chroma(darkColorRgb.hex()).hex() as HexColor,
+      loContrast: darkColorRgb.hex() as HexColor,
     }
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/src/styles/compute-color-values.ts` around lines 104 - 111,
Simplify redundant wrapping for loContrast: instead of calling
chroma(lightColorRgb.hex()).hex() and chroma(darkColorRgb.hex()).hex(), use the
hex strings directly from lightColorRgb.hex() and darkColorRgb.hex() (cast to
HexColor as needed) while keeping hiContrast computed via
chroma(...).brighten(0.4)/darken(0.4). Ensure you update the loContrast return
values in the branch that uses lightColorRgb and the branch that uses
darkColorRgb to return lightColorRgb.hex() as HexColor and darkColorRgb.hex() as
HexColor respectively.