Add clarification for Bolt11 prefix for regtest#397
Merged
rustyrussell merged 2 commits intolightning:masterfrom Apr 30, 2018
Merged
Add clarification for Bolt11 prefix for regtest#397rustyrussell merged 2 commits intolightning:masterfrom
rustyrussell merged 2 commits intolightning:masterfrom
Conversation
The document (and also BIP-0173) does not clarify which prefix bitcoin regtest should use, but bitcoin-core seems to have settled on `bcrt`, thus the most concise way for bolt11 would be to use `lnbcrt...` currently c-lightning and lnd are not compatible if you want to pay invoices in regtest mode, see: - ElementsProject/lightning#1241 - lightningnetwork/lnd#882
sstone
added a commit
to ACINQ/eclair
that referenced
this pull request
Mar 23, 2018
pm47
pushed a commit
to ACINQ/eclair
that referenced
this pull request
Mar 23, 2018
|
See bitcoin/bips#664. And this comment from @sipa:
|
Contributor
Author
|
I understand that this is not necessarily something that needs to be strictly defined but oth I think it makes life much easier if all implementations use the same prefix (or make it configurable at least). And I think only implicit mention it in the |
Collaborator
|
I don't see a problem referencing it here; better to be clear. |
rustyrussell
approved these changes
Apr 11, 2018
|
I'm looking around trying to find some arguments why would we even need a different prefix for a regtest network, and I don't really see any, while there's a lot of reasons not to have it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The document (and also BIP-0173) does not clarify which prefix bitcoin regtest should use, but bitcoin-core seems to have settled on
bcrt(see bitcoin/bitcoin#12314 ), thus the most concise way for bolt11 would be to uselnbcrt...currently c-lightning and lnd are not compatible if you want to pay invoices in regtest mode, see: