BIP0173: Include bech32 prefix for regtest mode#664
Closed
stevenroose wants to merge 1 commit intobitcoin:masterfrom
Closed
BIP0173: Include bech32 prefix for regtest mode#664stevenroose wants to merge 1 commit intobitcoin:masterfrom
stevenroose wants to merge 1 commit intobitcoin:masterfrom
Conversation
A mismatch between implementation occurred on the bech32 prefix for regtest mode. Bitcoin Core decided to use the `bcrt` prefix in order for it to be distinguishable from the testnet prefix. btcd on the other hand uses the same prefix as testnet because of lack of a separate prefix specified in this BIP. Core: bitcoin/bitcoin#12314 btcd: btcsuite/btcd#1150
Contributor
Author
|
Even though a standard definition of regression test chain params would help integration testing between different implementations, f.e. for Lightning integration tests, I do agree with the argument that they should not be included in official BIPs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mismatch between implementation occurred on the bech32 prefix for
regtest mode. Bitcoin Core decided to use the
bcrtprefix in orderfor it to be distinguishable from the testnet prefix. btcd on the other
hand uses the same prefix as testnet because of lack of a separate
prefix specified in this BIP.
Core: bitcoin/bitcoin#12314
btcd: btcsuite/btcd#1150