Wrong BOLT11 prefix in regtest#1150
Merged
Roasbeef merged 1 commit intobtcsuite:masterfrom Apr 18, 2018
Merged
Conversation
stevenroose
added a commit
to stevenroose/bips
that referenced
this pull request
Mar 22, 2018
A mismatch between implementation occurred on the bech32 prefix for regtest mode. Bitcoin Core decided to use the `bcrt` prefix in order for it to be distinguishable from the testnet prefix. btcd on the other hand uses the same prefix as testnet because of lack of a separate prefix specified in this BIP. Core: bitcoin/bitcoin#12314 btcd: btcsuite/btcd#1150
Contributor
|
I can't find any mention of this prefix in either BOLT11 or BIP 173 (bech32). So btcd doesn't use a wrong prefix, just a different one from Core. |
Contributor
Author
|
сс @DanielWeigl |
|
@stevenroose yes, thats true - but that also makes it impossible to test payments to invoices across different implementations in regtest I also already proposed to add a clarification to bolt11 lightning/bolts#397 I think it would make sense to have a common format in regtest, or? |
|
FYI, current state:
(all nodes run in regtest) So, |
b39bae2 to
04fd662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially was observed in
lndproject for this issue lightningnetwork/lnd#882if to try to generate invoice for
regtestnet, we get encoded invoice with wrong prefix in human readable part