Publish with namespaced JDK9 module name#547
Conversation
Fixes lightbend#546. Adds Automatic-Module-Name: typesafe.config, rather than defaulting to the very generic module name of config that the JVM selects.
|
Might be better if someone who knows more about the JDK9 module stuff looks at this, rather than me, since if this were wrong I couldn't tell you :-) but fine with me to merge once CI passes (which seems to be a matter of the sbt-osgi update you mentioned). |
ktoso
left a comment
There was a problem hiding this comment.
Released sbt osgi sbt/sbt-osgi#51
|
The module name is ok. I guess one could debate about LGTM |
|
Making it |
|
That's what I said... don't discuss and it's good as is. |
|
No objections here as well. |
Fixes lightbend#546. Adds Automatic-Module-Name: typesafe.config, rather than defaulting to the very generic module name of config that the JVM selects.
Fixes #546.
Adds
Automatic-Module-Name: typesafe.config, rather than defaulting to the very generic module name ofconfigthat the JVM selects.This PR depends on sbt-osgi 0.9.3 being published for sbt 0.13 (it's been published for sbt 1.0 but not 0.13) to get sbt/sbt-osgi#48.