Never pass null ConfigOrigin to PathParser.parsePathNodeExpression#538
Merged
ktoso merged 1 commit intolightbend:masterfrom Feb 21, 2018
Merged
Never pass null ConfigOrigin to PathParser.parsePathNodeExpression#538ktoso merged 1 commit intolightbend:masterfrom
ktoso merged 1 commit intolightbend:masterfrom
Conversation
This was causing NPEs on certain parse errors while trying to construct a ConfigException
Contributor
Author
|
CLA signed |
Contributor
|
Thanks, makes sense! Should plan to merge this before the next release. Tests would not be bad, here (potentially to verify the right error is thrown with the right line number in it), if anyone wants to take a crack at that. |
ktoso
approved these changes
Feb 21, 2018
Contributor
Author
|
Thanks, and sorry, I would have loved to add a test, but my time is currently a bit limited, and I am not yet familiar with the build system. |
Contributor
|
Thanks for the contrib regardless! |
aalleexxeeii
pushed a commit
to aalleexxeeii/typesafe-config
that referenced
this pull request
Jun 6, 2018
…ightbend#538) This was causing NPEs on certain parse errors while trying to construct a ConfigException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing NPEs on certain parse errors while trying to construct a ConfigException