Migrate to sbt 0.13.16#483
Merged
dwijnand merged 1 commit intolightbend:masterfrom Aug 14, 2017
dwijnand:sbt-0.13.16
Merged
Conversation
Contributor
|
Thanks! This looks generally good to me, but I haven't been staying informed on sbt changes; if @eed3si9n or others more in the loop want to review that would be welcome. I'll plan to merge after a bit if nobody has any comments. |
eed3si9n
suggested changes
Aug 4, 2017
Contributor
eed3si9n
left a comment
There was a problem hiding this comment.
Given that it's on Typesafe org, we should stick to more idiomatic sbt styling.
build.sbt
Outdated
| def scmUrl = "git://github.com/typesafehub/config.git" | ||
| } | ||
|
|
||
| lazy val commonSettings: Seq[Setting[_]] = Def settings ( |
build.sbt
Outdated
| javaVersionPrefix in javaVersionCheck := None | ||
| ) | ||
|
|
||
| lazy val root = project in file(".") settings ( |
Contributor
There was a problem hiding this comment.
(project in file("."))
.settings(...)
build.sbt
Outdated
| simpleLibJava, simpleAppJava, complexAppJava | ||
| ) | ||
|
|
||
| lazy val configLib = Project("config", file("config")) settings ( |
build.sbt
Outdated
| OsgiKeys.exportPackage := Seq("com.typesafe.config", "com.typesafe.config.impl"), | ||
| publish := sys.error("use publishSigned instead of plain publish"), | ||
| publishLocal := sys.error("use publishLocalSigned instead of plain publishLocal") | ||
| ) enablePlugins SbtOsgi dependsOn testLib % "test->test" |
Contributor
There was a problem hiding this comment.
.enablePlugins(...)
.dependsOn(...)| import sbt._, Keys._ | ||
|
|
||
| // from https://raw.github.com/paulp/scala-improving/master/project/PublishToSonatype.scala | ||
| abstract class PublishToSonatype { |
Contributor
There was a problem hiding this comment.
Why an abstract class here?
Shouldn't it be an object or an AutoPlugin?
Contributor
Author
There was a problem hiding this comment.
It has undefined defs.
Contributor
Author
|
Who defines sbt's idioms, you infix-hater :P (your requested changes coming right up) |
aalleexxeeii
pushed a commit
to aalleexxeeii/typesafe-config
that referenced
this pull request
Jun 6, 2018
Migrate to sbt 0.13.16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was passing by, seeing if I find a nice solution to #423, and ended up upgrading the build instead.
Feedback welcome - I'm happy to dial back some opinions :)