unix: fix gcc atomics feature check#2888
Closed
bnoordhuis wants to merge 0 commit intolibuv:v1.xfrom
Closed
Conversation
richardlau
approved these changes
Jun 17, 2020
addaleax
approved these changes
Jun 17, 2020
santigimeno
approved these changes
Jun 18, 2020
bnoordhuis
added a commit
to bnoordhuis/libuv
that referenced
this pull request
Jun 18, 2020
`__atomic_load_n()` and friends were added in gcc 4.7.0 but we still have some centos6 machines with a vintage gcc 4.4.7 from 2012 in the CI matrix. PR-URL: libuv#2888 Refs: libuv#2886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
be4b295 to
41f5732
Compare
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
`__atomic_load_n()` and friends were added in gcc 4.7.0 but we still have some centos6 machines with a vintage gcc 4.4.7 from 2012 in the CI matrix. PR-URL: libuv#2888 Refs: libuv#2886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
`__atomic_load_n()` and friends were added in gcc 4.7.0 but we still have some centos6 machines with a vintage gcc 4.4.7 from 2012 in the CI matrix. PR-URL: libuv/libuv#2888 Refs: libuv/libuv#2886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
`__atomic_load_n()` and friends were added in gcc 4.7.0 but we still have some centos6 machines with a vintage gcc 4.4.7 from 2012 in the CI matrix. PR-URL: libuv/libuv#2888 Refs: libuv/libuv#2886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__atomic_load_n()and friends were added in gcc 4.7.0 but we stillhave some centos6 machines with a vintage gcc 4.4.7 from 2012 in the
CI matrix.
CI: https://ci.nodejs.org/job/libuv-test-commit/1937/