Skip to content

unix: use relaxed loads/stores for feature checks#2886

Merged
bnoordhuis merged 1 commit intolibuv:v1.xfrom
bnoordhuis:fix2884
Jun 16, 2020
Merged

unix: use relaxed loads/stores for feature checks#2886
bnoordhuis merged 1 commit intolibuv:v1.xfrom
bnoordhuis:fix2884

Conversation

@bnoordhuis
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis commented Jun 12, 2020 •
edited
Loading

Make ThreadSanitizer stop complaining about the static variables that
libuv uses to record the presence (or lack) of system calls and other
kernel features.

Fixes: #2884
CI: https://ci.nodejs.org/job/libuv-test-commit/1933/
CI: https://ci.nodejs.org/job/libuv-test-commit/1934/

vtjnash
vtjnash approved these changes Jun 12, 2020
View reviewed changes
Comment thread src/uv-common.h
@bnoordhuis bnoordhuis mentioned this pull request Jun 14, 2020
Closed
@bnoordhuis
unix: use relaxed loads/stores for feature checks
c70dd70 
Make ThreadSanitizer stop complaining about the static variables that
libuv uses to record the presence (or lack) of system calls and other
kernel features.

Fixes: libuv#2884
PR-URL: libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
@bnoordhuis bnoordhuis merged commit c70dd70 into libuv:v1.x Jun 16, 2020
@bnoordhuis bnoordhuis deleted the fix2884 branch June 16, 2020 09:45
@santigimeno
Copy link
Copy Markdown
Member

santigimeno commented Jun 17, 2020 •
edited
Loading

@bnoordhuis this change seems to cause build issues in the centos6 boxes. See: https://ci.nodejs.org/job/libuv-test-commit-linux/nodes=centos6-64/2004/console and https://ci.nodejs.org/job/libuv-test-commit-linux/nodes=centos6-64-gcc44/2004/console

@bnoordhuis
Copy link
Copy Markdown
Member Author

bnoordhuis commented Jun 17, 2020

Mea culpa, I could swear the run was green when I last checked it. #2888 should fix it.

bnoordhuis added a commit to bnoordhuis/libuv that referenced this pull request Jun 18, 2020
@bnoordhuis
unix: fix gcc atomics feature check
41f5732 
`__atomic_load_n()` and friends were added in gcc 4.7.0 but we still
have some centos6 machines with a vintage gcc 4.4.7 from 2012 in the
CI matrix.

PR-URL: libuv#2888
Refs: libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@lw
Copy link
Copy Markdown

lw commented Jul 4, 2020

@bnoordhuis It seems that when at some point you updated this PR you happened to revert the fixes to uv__hrtime (see this diff) and that's probably why we're still seeing issues in #2884. Any chance we could get those fixes back in? Thanks!

bnoordhuis added a commit that referenced this pull request Jul 10, 2020
@bnoordhuis
unix: use relaxed loads/stores for clock id
10a9c25 
This was part of commit c70dd70 ("unix: use relaxed loads/stores for
feature checks") and was reviewed as such but I accidentally dropped
it in the rebase before the final merge.

Fixes: #2884
PR-URL: #2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
@sthagen sthagen mentioned this pull request Jul 19, 2020
Merged
@lw lw mentioned this pull request Oct 28, 2020
Closed
JeffroMF pushed a commit to JeffroMF/libuv that referenced this pull request May 16, 2022
@bnoordhuis @JeffroMF
unix: use relaxed loads/stores for feature checks
35573eb 
Make ThreadSanitizer stop complaining about the static variables that
libuv uses to record the presence (or lack) of system calls and other
kernel features.

Fixes: libuv#2884
PR-URL: libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
JeffroMF pushed a commit to JeffroMF/libuv that referenced this pull request May 16, 2022
@bnoordhuis @JeffroMF
unix: fix gcc atomics feature check
b4c751d 
`__atomic_load_n()` and friends were added in gcc 4.7.0 but we still
have some centos6 machines with a vintage gcc 4.4.7 from 2012 in the
CI matrix.

PR-URL: libuv#2888
Refs: libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
JeffroMF pushed a commit to JeffroMF/libuv that referenced this pull request May 16, 2022
@bnoordhuis @JeffroMF
unix: use relaxed loads/stores for clock id
3bdab6b 
This was part of commit c70dd70 ("unix: use relaxed loads/stores for
feature checks") and was reviewed as such but I accidentally dropped
it in the rebase before the final merge.

Fixes: libuv#2884
PR-URL: libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Jul 23, 2025
@bnoordhuis @liujinye-sys
unix: use relaxed loads/stores for feature checks
ff46dcc 
Make ThreadSanitizer stop complaining about the static variables that
libuv uses to record the presence (or lack) of system calls and other
kernel features.

Fixes: libuv/libuv#2884
PR-URL: libuv/libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Jul 23, 2025
@bnoordhuis @liujinye-sys
unix: fix gcc atomics feature check
9233898 
`__atomic_load_n()` and friends were added in gcc 4.7.0 but we still
have some centos6 machines with a vintage gcc 4.4.7 from 2012 in the
CI matrix.

PR-URL: libuv/libuv#2888
Refs: libuv/libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Jul 23, 2025
@bnoordhuis @liujinye-sys
unix: use relaxed loads/stores for clock id
dec7003 
This was part of commit c70dd70 ("unix: use relaxed loads/stores for
feature checks") and was reviewed as such but I accidentally dropped
it in the rebase before the final merge.

Fixes: libuv/libuv#2884
PR-URL: libuv/libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Dec 16, 2025
@bnoordhuis @openvela-robot
unix: use relaxed loads/stores for feature checks
44db10a 
Make ThreadSanitizer stop complaining about the static variables that
libuv uses to record the presence (or lack) of system calls and other
kernel features.

Fixes: libuv/libuv#2884
PR-URL: libuv/libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Dec 16, 2025
@bnoordhuis @openvela-robot
unix: fix gcc atomics feature check
5317369 
`__atomic_load_n()` and friends were added in gcc 4.7.0 but we still
have some centos6 machines with a vintage gcc 4.4.7 from 2012 in the
CI matrix.

PR-URL: libuv/libuv#2888
Refs: libuv/libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Dec 16, 2025
@bnoordhuis @openvela-robot
unix: use relaxed loads/stores for clock id
bd40f9e 
This was part of commit c70dd70 ("unix: use relaxed loads/stores for
feature checks") and was reviewed as such but I accidentally dropped
it in the rebase before the final merge.

Fixes: libuv/libuv#2884
PR-URL: libuv/libuv#2886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

+1 more reviewer

@addaleax addaleax addaleax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data race in linux uv__hrtime() when setting fast_clock_id

5 participants

@bnoordhuis @santigimeno @lw @vtjnash @addaleax