Skip to content

fix(perf): replace rust-libp2p-quinn/ with rust-libp2p/master#246

Merged
mxinden merged 2 commits intomasterfrom
perf-rust-libp2p-quinn
Aug 1, 2023
Merged

fix(perf): replace rust-libp2p-quinn/ with rust-libp2p/master#246
mxinden merged 2 commits intomasterfrom
perf-rust-libp2p-quinn

Conversation

@mxinden
Copy link
Copy Markdown
Member

@mxinden mxinden commented Aug 1, 2023

With libp2p/rust-libp2p#3454 merged we can now test the new rust-libp2p QUIC implementation based on upstream quinn directly from rust-libp2p master.

This commit does the following in libp2p/test-plans:

  1. Remove the perf/impl/rust-libp2p-quinn implementation.
  2. Introduce the perf/impl/rust-libp2p/master version of the rust-libp2p implementation.

We can promote the latter to a proper version on the next rust-libp2p release.

With libp2p/rust-libp2p#3454 merged we can now test the
new rust-libp2p QUIC implementation based on upstream quinn directly from
rust-libp2p `master`.

This commit does the following in libp2p/test-plans:

1. Remove the `perf/impl/rust-libp2p-quinn` implementation.
2. Introduce the `perf/impl/rust-libp2p/master` version of the rust-libp2p implementation.

We can promote the latter to a proper version on the next rust-libp2p release.
@mxinden
Copy link
Copy Markdown
Member Author

mxinden commented Aug 1, 2023

Pending perf GitHub Action CI run: https://github.com/libp2p/test-plans/actions/runs/5727030855/job/15518628399

@mxinden
Copy link
Copy Markdown
Member Author

mxinden commented Aug 1, 2023

One can now compare rust-libp2p/v0.52 with rust-libp2p/master at the bottom of the dashboard.

https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf-rust-libp2p-quinn#branch

@mxinden
Copy link
Copy Markdown
Member Author

mxinden commented Aug 1, 2023

Merging here since it only touches perf/. Happy to do follow-up changes.

//CC @thomaseizinger

@mxinden mxinden merged commit ffc7ae0 into master Aug 1, 2023
@mxinden mxinden deleted the perf-rust-libp2p-quinn branch August 1, 2023 14:40
@mxinden
Copy link
Copy Markdown
Member Author

mxinden commented Aug 1, 2023

One can now compare rust-libp2p/v0.52 with rust-libp2p/master at the bottom of the dashboard.

https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf-rust-libp2p-quinn#branch

Also //CC @kpp in case you want to see the fruits of your work.

mxinden added a commit that referenced this pull request Aug 24, 2023
Implementation has been removed with #246.
mxinden added a commit that referenced this pull request Aug 24, 2023
Implementation has been removed with #246.
codemaestro64 pushed a commit to codemaestro64/test-plans that referenced this pull request Oct 28, 2025
…#246)

With libp2p/rust-libp2p#3454 merged we can now test the
new rust-libp2p QUIC implementation based on upstream quinn directly from
rust-libp2p `master`.

This commit does the following in libp2p/test-plans:

1. Remove the `perf/impl/rust-libp2p-quinn` implementation.
2. Introduce the `perf/impl/rust-libp2p/master` version of the rust-libp2p implementation.

We can promote the latter to a proper version on the next rust-libp2p release.
codemaestro64 pushed a commit to codemaestro64/test-plans that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant