refactor(quic): rewrite quic using quinn by kpp · Pull Request #3454 · libp2p/rust-libp2p

kpp · 2023-02-11T22:58:07Z

Description

Rewrite quic using quinn instead of quinn-proto. libp2p-quic::endpoint::Driver is eliminated (and that hard quinn-proto machinery). Also:

ECN bits are handled
Support Generic Send Offload (GSO)

Notes

This PR preserves the original API and naming.

Testing hole punching:

cargo r -p relay-server-example -- --secret-key-seed 1 --port 15353

cargo r -p dcutr -- --mode listen --secret-key-seed 2 --relay-address /ip4/127.0.0.1/udp/15353/quic-v1/p2p/12D3KooWPjceQrSwdWXPyLLeABRXmuqt69Rg3sBYbU1Nft9HyQ6X

cargo r -p dcutr -- --mode dial --secret-key-seed 3 --relay-address /ip4/127.0.0.1/udp/15353/quic-v1/p2p/12D3KooWPjceQrSwdWXPyLLeABRXmuqt69Rg3sBYbU1Nft9HyQ6X --remote-peer-id 12D3KooWH3uVF6wv47WnArKHk5p6cvgCJEb74UTmxztmQDc298L3

Links to any relevant issues

Open Questions

Change checklist

I have performed a self-review of my own code
I have made corresponding changes to the documentation
~~I have added tests that prove my fix is effective or that my feature works~~
A changelog entry has been made in the appropriate crates

TODOs

Remove direct usage of quinn-proto
Fix doc comments
Delete commented code
Think how to close connection (code_reason + wait in poll_close?)
Fix tests
Update libp2p-perf to 0.51.0 (rust/: update dependencies mxinden/libp2p-perf#91)
~~Get rid of BoxedFuture in connection~~
Bench code
Hole punching

mxinden · 2023-02-13T11:08:49Z

@kpp can you expand on the difference to #2801?

kpp · 2023-02-13T13:32:33Z

This one is fresh, uses all features from master but with less code. I tried to update #2801 but it turned out it was easier to rewrite it.

kpp

Left comments on close/poll_close. I am not sure how to resolve them.

transports/quic/src/connection.rs

transports/quic/src/transport.rs

fix(quic/stream): return error on read

fix(quic/connection): await connection.closed

mergify · 2023-07-27T15:45:54Z

This pull request has merge conflicts. Could you please resolve them @kpp? 🙏

…uic_quinn

mxinden

Thank you @kpp for all the work on this pull request.

I will go ahead and merge here 🎉.

Most prominently, includes libp2p/rust-libp2p#3454.

thomaseizinger · 2023-07-29T15:34:07Z

Awesome work @kpp and @mxinden!

@mxinden Mind updating the roadmap to mark this as completed?

Done with #3454. Pull-Request: #4277.

With libp2p/rust-libp2p#3454 merged we can now test the new rust-libp2p QUIC implementation based on upstream quinn directly from rust-libp2p `master`. This commit does the following in libp2p/test-plans: 1. Remove the `perf/impl/rust-libp2p-quinn` implementation. 2. Introduce the `perf/impl/rust-libp2p/master` version of the rust-libp2p implementation. We can promote the latter to a proper version on the next rust-libp2p release.

Rewrite quic using quinn instead of quinn-proto. libp2p-quic::endpoint::Driver is eliminated (and that hard quinn-proto machinery). Also: - ECN bits are handled - Support Generic Send Offload (GSO) Pull-Request: #3454.

Done with #3454. Pull-Request: #4277.

…#246) With libp2p/rust-libp2p#3454 merged we can now test the new rust-libp2p QUIC implementation based on upstream quinn directly from rust-libp2p `master`. This commit does the following in libp2p/test-plans: 1. Remove the `perf/impl/rust-libp2p-quinn` implementation. 2. Introduce the `perf/impl/rust-libp2p/master` version of the rust-libp2p implementation. We can promote the latter to a proper version on the next rust-libp2p release.

kpp added 10 commits February 10, 2023 00:27

Init (it compiles)

8bd903d

Implement fn dial

8bce874

Handle quic version

2fa3408

Implement tokio/async-std switch

22b7944

Fix one error handling

3c77392

Revisit todo

729ebf9

Fix one error handling

ff2dc4b

Reduce the number of warnings

a288c97

Remove a lot of commented code

a5493a3

Merge branch 'master' into quic_quinn

b781c87

kpp added 10 commits February 13, 2023 16:27

Remove quinn-proto dep

ce2403d

Remove redundant Arcs

b1560dd

Add more comments

8171862

Merge branch 'master' into quic_quinn

dd394db

More comments

a1789af

More comments

b46feb7

Remove unused commented code

b947b12

Fix old tests to match new structs

0bce473

Merge branch 'master' into quic_quinn

26ac662

Rename endpoint.rs -> config.rs

7e788b6

kpp changed the title ~~WIP: Rewrite quic using quinn~~ Rewrite quic using quinn Feb 14, 2023

kpp added 2 commits February 15, 2023 12:06

Fix doc links

953ce83

cargo fmt

df0f789

kpp changed the title ~~Rewrite quic using quinn~~ refactor(quic): rewrite quic using quinn Feb 15, 2023

Merge branch 'master' into quic_quinn

e8cbd5a

kpp force-pushed the quic_quinn branch from b80bbae to e8cbd5a Compare February 15, 2023 16:22

kpp commented Feb 15, 2023

View reviewed changes

transports/quic/src/connection.rs Outdated Show resolved Hide resolved

transports/quic/src/transport.rs Show resolved Hide resolved

Merge branch 'master' into quic_quinn

ee7c2cd

kpp and others added 2 commits July 24, 2023 19:44

Merge pull request #29 from mxinden/quic_quinn

19ff4d9

fix(quic/stream): return error on read

fix(quic/connection): await connection.closed

8b65105

mxinden mentioned this pull request Jul 24, 2023

fix(quic/connection): await connection.closed kpp/rust-libp2p#30

Merged

4 tasks

Merge pull request #30 from mxinden/quinn-closed

d275e85

fix(quic/connection): await connection.closed

mxinden mentioned this pull request Jul 27, 2023

fix(quic): improve listener socket selection when dialing #4259

Open

mxinden added 2 commits July 27, 2023 17:39

Revert back to 0.0.0.0 listen_on in dcutr example

0b08770

Bump version

b6bd51f

mxinden added 4 commits July 27, 2023 17:48

Merge branch 'master' of https://github.com/libp2p/rust-libp2p into q…

0a842b8

…uic_quinn

Try hiding Provider trait

fccd979

Fix doc comment

cfd147e

Revert hiding Provider trait

a92954a

mxinden approved these changes Jul 28, 2023

View reviewed changes

mxinden added the send-it label Jul 28, 2023

mergify bot merged commit 4e1fa9b into libp2p:master Jul 28, 2023

mxinden added a commit to mxinden/rust-libp2p-server that referenced this pull request Jul 29, 2023

chore(Cargo.toml): update to latest libp2p master

b6f2ffe

Most prominently, includes libp2p/rust-libp2p#3454.

mxinden mentioned this pull request Jul 29, 2023

chore(Cargo.toml): update to latest libp2p master mxinden/rust-libp2p-server#252

Merged

mxinden mentioned this pull request Jul 31, 2023

chore(roadmap): move QUIC quinn to done #4277

Merged

4 tasks

mergify bot pushed a commit that referenced this pull request Jul 31, 2023

chore(roadmap): move QUIC quinn to done

c86b665

Done with #3454. Pull-Request: #4277.

kpp deleted the quic_quinn branch August 1, 2023 12:35

kpp mentioned this pull request Aug 1, 2023

Tracking issue for QUIC support paritytech/polkadot-sdk#536

Open

10 tasks

mxinden mentioned this pull request Aug 1, 2023

fix(perf): replace rust-libp2p-quinn/ with rust-libp2p/master libp2p/test-plans#246

Merged

jxs mentioned this pull request Aug 2, 2023

or quic transport with tcp AgeManning/lighthouse#5

Merged

thomaseizinger pushed a commit that referenced this pull request Aug 20, 2023

chore(roadmap): move QUIC quinn to done

97f2190

Done with #3454. Pull-Request: #4277.

Itsusinn mentioned this pull request Aug 27, 2024

支持quic传输 EasyTier/EasyTier#284

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(quic): rewrite quic using quinn#3454

refactor(quic): rewrite quic using quinn#3454
mergify[bot] merged 83 commits intolibp2p:masterfrom
kpp:quic_quinn

kpp commented Feb 11, 2023 •

edited

Loading

Uh oh!

mxinden commented Feb 13, 2023

Uh oh!

kpp commented Feb 13, 2023

Uh oh!

kpp left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Jul 27, 2023

Uh oh!

mxinden left a comment

Uh oh!

thomaseizinger commented Jul 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kpp commented Feb 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes

Links to any relevant issues

Open Questions

Change checklist

TODOs

Uh oh!

mxinden commented Feb 13, 2023

Uh oh!

kpp commented Feb 13, 2023

Uh oh!

kpp left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Jul 27, 2023

Uh oh!

mxinden left a comment

Choose a reason for hiding this comment

Uh oh!

thomaseizinger commented Jul 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kpp commented Feb 11, 2023 •

edited

Loading

kpp left a comment •

edited

Loading