feat(swarm): remove KeepAlive::Until from OneshotHandler#4677
Merged
mergify[bot] merged 7 commits intolibp2p:masterfrom Oct 20, 2023
Merged
feat(swarm): remove KeepAlive::Until from OneshotHandler#4677mergify[bot] merged 7 commits intolibp2p:masterfrom
KeepAlive::Until from OneshotHandler#4677mergify[bot] merged 7 commits intolibp2p:masterfrom
Conversation
Contributor
thomaseizinger
left a comment
There was a problem hiding this comment.
Awesome, thank you!
Just one comment.
KeepAlive::UntilKeepAlive::Until from OneshotHandler`
KeepAlive::Until from OneshotHandler`KeepAlive::Until from OneshotHandler
4 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
This pull request has merge conflicts. Could you please resolve them @leonzchang? 🙏 |
thomaseizinger
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: #3844.
Related: #4656.
Notes & open questions
Change checklist